Complex classes like MemberReservation often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use MemberReservation, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 5 | class MemberReservation |
||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var string $AccountNo |
||
| 10 | */ |
||
| 11 | protected $AccountNo = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var int $ID_Member |
||
| 15 | */ |
||
| 16 | protected $ID_Member = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $ResAccountNo |
||
| 20 | */ |
||
| 21 | protected $ResAccountNo = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var \DateTime $ArrivalDate |
||
| 25 | */ |
||
| 26 | protected $ArrivalDate = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var \DateTime $DepartureDate |
||
| 30 | */ |
||
| 31 | protected $DepartureDate = null; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var string $Discriminator |
||
| 35 | */ |
||
| 36 | protected $Discriminator = null; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var string $RoomNo |
||
| 40 | */ |
||
| 41 | protected $RoomNo = null; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var string $AccountName |
||
| 45 | */ |
||
| 46 | protected $AccountName = null; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var float $TotalSoldeA |
||
| 50 | */ |
||
| 51 | protected $TotalSoldeA = null; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @var float $TotalSoldeB |
||
| 55 | */ |
||
| 56 | protected $TotalSoldeB = null; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var float $TotalSoldeC |
||
| 60 | */ |
||
| 61 | protected $TotalSoldeC = null; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @var float $TotalSoldeD |
||
| 65 | */ |
||
| 66 | protected $TotalSoldeD = null; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @var float $TotalSubFolioA |
||
| 70 | */ |
||
| 71 | protected $TotalSubFolioA = null; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @var float $TotalSubFolioB |
||
| 75 | */ |
||
| 76 | protected $TotalSubFolioB = null; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @var float $TotalSubFolioC |
||
| 80 | */ |
||
| 81 | protected $TotalSubFolioC = null; |
||
| 82 | |||
| 83 | /** |
||
| 84 | * @var float $TotalSubFolioD |
||
| 85 | */ |
||
| 86 | protected $TotalSubFolioD = null; |
||
| 87 | |||
| 88 | /** |
||
| 89 | * @var float $TotalFolios |
||
| 90 | */ |
||
| 91 | protected $TotalFolios = null; |
||
| 92 | |||
| 93 | /** |
||
| 94 | * @var string $AccountStatus |
||
| 95 | */ |
||
| 96 | protected $AccountStatus = null; |
||
| 97 | |||
| 98 | /** |
||
| 99 | * @param int $ID_Member |
||
| 100 | * @param \DateTime $ArrivalDate |
||
| 101 | * @param \DateTime $DepartureDate |
||
| 102 | * @param float $TotalSoldeA |
||
| 103 | * @param float $TotalSoldeB |
||
| 104 | * @param float $TotalSoldeC |
||
| 105 | * @param float $TotalSoldeD |
||
| 106 | * @param float $TotalSubFolioA |
||
| 107 | * @param float $TotalSubFolioB |
||
| 108 | * @param float $TotalSubFolioC |
||
| 109 | * @param float $TotalSubFolioD |
||
| 110 | * @param float $TotalFolios |
||
| 111 | */ |
||
| 112 | public function __construct($ID_Member, \DateTime $ArrivalDate, \DateTime $DepartureDate, $TotalSoldeA, $TotalSoldeB, $TotalSoldeC, $TotalSoldeD, $TotalSubFolioA, $TotalSubFolioB, $TotalSubFolioC, $TotalSubFolioD, $TotalFolios) |
||
| 127 | |||
| 128 | /** |
||
| 129 | * @return string |
||
| 130 | */ |
||
| 131 | public function getAccountNo() |
||
| 135 | |||
| 136 | /** |
||
| 137 | * @param string $AccountNo |
||
| 138 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 139 | */ |
||
| 140 | public function setAccountNo($AccountNo) |
||
| 145 | |||
| 146 | /** |
||
| 147 | * @return int |
||
| 148 | */ |
||
| 149 | public function getID_Member() |
||
| 153 | |||
| 154 | /** |
||
| 155 | * @param int $ID_Member |
||
| 156 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 157 | */ |
||
| 158 | public function setID_Member($ID_Member) |
||
| 163 | |||
| 164 | /** |
||
| 165 | * @return string |
||
| 166 | */ |
||
| 167 | public function getResAccountNo() |
||
| 171 | |||
| 172 | /** |
||
| 173 | * @param string $ResAccountNo |
||
| 174 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 175 | */ |
||
| 176 | public function setResAccountNo($ResAccountNo) |
||
| 181 | |||
| 182 | /** |
||
| 183 | * @return \DateTime |
||
| 184 | */ |
||
| 185 | public function getArrivalDate() |
||
| 197 | |||
| 198 | /** |
||
| 199 | * @param \DateTime $ArrivalDate |
||
| 200 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 201 | */ |
||
| 202 | public function setArrivalDate(\DateTime $ArrivalDate) |
||
| 207 | |||
| 208 | /** |
||
| 209 | * @return \DateTime |
||
| 210 | */ |
||
| 211 | public function getDepartureDate() |
||
| 223 | |||
| 224 | /** |
||
| 225 | * @param \DateTime $DepartureDate |
||
| 226 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 227 | */ |
||
| 228 | public function setDepartureDate(\DateTime $DepartureDate) |
||
| 233 | |||
| 234 | /** |
||
| 235 | * @return string |
||
| 236 | */ |
||
| 237 | public function getDiscriminator() |
||
| 241 | |||
| 242 | /** |
||
| 243 | * @param string $Discriminator |
||
| 244 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 245 | */ |
||
| 246 | public function setDiscriminator($Discriminator) |
||
| 251 | |||
| 252 | /** |
||
| 253 | * @return string |
||
| 254 | */ |
||
| 255 | public function getRoomNo() |
||
| 259 | |||
| 260 | /** |
||
| 261 | * @param string $RoomNo |
||
| 262 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 263 | */ |
||
| 264 | public function setRoomNo($RoomNo) |
||
| 269 | |||
| 270 | /** |
||
| 271 | * @return string |
||
| 272 | */ |
||
| 273 | public function getAccountName() |
||
| 277 | |||
| 278 | /** |
||
| 279 | * @param string $AccountName |
||
| 280 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 281 | */ |
||
| 282 | public function setAccountName($AccountName) |
||
| 287 | |||
| 288 | /** |
||
| 289 | * @return float |
||
| 290 | */ |
||
| 291 | public function getTotalSoldeA() |
||
| 295 | |||
| 296 | /** |
||
| 297 | * @param float $TotalSoldeA |
||
| 298 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 299 | */ |
||
| 300 | public function setTotalSoldeA($TotalSoldeA) |
||
| 305 | |||
| 306 | /** |
||
| 307 | * @return float |
||
| 308 | */ |
||
| 309 | public function getTotalSoldeB() |
||
| 313 | |||
| 314 | /** |
||
| 315 | * @param float $TotalSoldeB |
||
| 316 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 317 | */ |
||
| 318 | public function setTotalSoldeB($TotalSoldeB) |
||
| 323 | |||
| 324 | /** |
||
| 325 | * @return float |
||
| 326 | */ |
||
| 327 | public function getTotalSoldeC() |
||
| 331 | |||
| 332 | /** |
||
| 333 | * @param float $TotalSoldeC |
||
| 334 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 335 | */ |
||
| 336 | public function setTotalSoldeC($TotalSoldeC) |
||
| 341 | |||
| 342 | /** |
||
| 343 | * @return float |
||
| 344 | */ |
||
| 345 | public function getTotalSoldeD() |
||
| 349 | |||
| 350 | /** |
||
| 351 | * @param float $TotalSoldeD |
||
| 352 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 353 | */ |
||
| 354 | public function setTotalSoldeD($TotalSoldeD) |
||
| 359 | |||
| 360 | /** |
||
| 361 | * @return float |
||
| 362 | */ |
||
| 363 | public function getTotalSubFolioA() |
||
| 367 | |||
| 368 | /** |
||
| 369 | * @param float $TotalSubFolioA |
||
| 370 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 371 | */ |
||
| 372 | public function setTotalSubFolioA($TotalSubFolioA) |
||
| 377 | |||
| 378 | /** |
||
| 379 | * @return float |
||
| 380 | */ |
||
| 381 | public function getTotalSubFolioB() |
||
| 385 | |||
| 386 | /** |
||
| 387 | * @param float $TotalSubFolioB |
||
| 388 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 389 | */ |
||
| 390 | public function setTotalSubFolioB($TotalSubFolioB) |
||
| 395 | |||
| 396 | /** |
||
| 397 | * @return float |
||
| 398 | */ |
||
| 399 | public function getTotalSubFolioC() |
||
| 403 | |||
| 404 | /** |
||
| 405 | * @param float $TotalSubFolioC |
||
| 406 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 407 | */ |
||
| 408 | public function setTotalSubFolioC($TotalSubFolioC) |
||
| 413 | |||
| 414 | /** |
||
| 415 | * @return float |
||
| 416 | */ |
||
| 417 | public function getTotalSubFolioD() |
||
| 421 | |||
| 422 | /** |
||
| 423 | * @param float $TotalSubFolioD |
||
| 424 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 425 | */ |
||
| 426 | public function setTotalSubFolioD($TotalSubFolioD) |
||
| 431 | |||
| 432 | /** |
||
| 433 | * @return float |
||
| 434 | */ |
||
| 435 | public function getTotalFolios() |
||
| 439 | |||
| 440 | /** |
||
| 441 | * @param float $TotalFolios |
||
| 442 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 443 | */ |
||
| 444 | public function setTotalFolios($TotalFolios) |
||
| 449 | |||
| 450 | /** |
||
| 451 | * @return string |
||
| 452 | */ |
||
| 453 | public function getAccountStatus() |
||
| 457 | |||
| 458 | /** |
||
| 459 | * @param string $AccountStatus |
||
| 460 | * @return \Gueststream\PMS\IQWare\API\MemberReservation |
||
| 461 | */ |
||
| 462 | public function setAccountStatus($AccountStatus) |
||
| 467 | } |
||
| 468 |
Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property.
Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property..