Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class MemberModify |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $GUID |
||
| 10 | */ |
||
| 11 | protected $GUID = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var cMember $MemberInfos |
||
| 15 | */ |
||
| 16 | protected $MemberInfos = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $WebLogin |
||
| 20 | */ |
||
| 21 | protected $WebLogin = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var string $Password |
||
| 25 | */ |
||
| 26 | protected $Password = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @param int $GUID |
||
| 30 | * @param cMember $MemberInfos |
||
| 31 | * @param string $WebLogin |
||
| 32 | * @param string $Password |
||
| 33 | */ |
||
| 34 | public function __construct($GUID, $MemberInfos, $WebLogin, $Password) |
||
| 41 | |||
| 42 | /** |
||
| 43 | * @return int |
||
| 44 | */ |
||
| 45 | public function getGUID() |
||
| 49 | |||
| 50 | /** |
||
| 51 | * @param int $GUID |
||
| 52 | * @return \Gueststream\PMS\IQWare\API\MemberModify |
||
| 53 | */ |
||
| 54 | public function setGUID($GUID) |
||
| 59 | |||
| 60 | /** |
||
| 61 | * @return cMember |
||
| 62 | */ |
||
| 63 | public function getMemberInfos() |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @param cMember $MemberInfos |
||
| 70 | * @return \Gueststream\PMS\IQWare\API\MemberModify |
||
| 71 | */ |
||
| 72 | public function setMemberInfos($MemberInfos) |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @return string |
||
| 80 | */ |
||
| 81 | public function getWebLogin() |
||
| 85 | |||
| 86 | /** |
||
| 87 | * @param string $WebLogin |
||
| 88 | * @return \Gueststream\PMS\IQWare\API\MemberModify |
||
| 89 | */ |
||
| 90 | public function setWebLogin($WebLogin) |
||
| 95 | |||
| 96 | /** |
||
| 97 | * @return string |
||
| 98 | */ |
||
| 99 | public function getPassword() |
||
| 103 | |||
| 104 | /** |
||
| 105 | * @param string $Password |
||
| 106 | * @return \Gueststream\PMS\IQWare\API\MemberModify |
||
| 107 | */ |
||
| 108 | public function setPassword($Password) |
||
| 113 | } |
||
| 114 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.