Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | class GroupReservations |
||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $ID_Account |
||
| 10 | */ |
||
| 11 | protected $ID_Account = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var int $AccountNo |
||
| 15 | */ |
||
| 16 | protected $AccountNo = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $RoomNo |
||
| 20 | */ |
||
| 21 | protected $RoomNo = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var string $AccountName |
||
| 25 | */ |
||
| 26 | protected $AccountName = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var int $ID_RoomType |
||
| 30 | */ |
||
| 31 | protected $ID_RoomType = null; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var string $RoomTypeName |
||
| 35 | */ |
||
| 36 | protected $RoomTypeName = null; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @var int $RoomQty |
||
| 40 | */ |
||
| 41 | protected $RoomQty = null; |
||
| 42 | |||
| 43 | /** |
||
| 44 | * @var int $GuestTotal |
||
| 45 | */ |
||
| 46 | protected $GuestTotal = null; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * @var \DateTime $ArrivalDate |
||
| 50 | */ |
||
| 51 | protected $ArrivalDate = null; |
||
| 52 | |||
| 53 | /** |
||
| 54 | * @var \DateTime $DepartureDate |
||
| 55 | */ |
||
| 56 | protected $DepartureDate = null; |
||
| 57 | |||
| 58 | /** |
||
| 59 | * @var int $ID_Group |
||
| 60 | */ |
||
| 61 | protected $ID_Group = null; |
||
| 62 | |||
| 63 | /** |
||
| 64 | * @var int $AccountStatus |
||
| 65 | */ |
||
| 66 | protected $AccountStatus = null; |
||
| 67 | |||
| 68 | /** |
||
| 69 | * @var string $AccountStatusString |
||
| 70 | */ |
||
| 71 | protected $AccountStatusString = null; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @var string $ID_RateCode |
||
| 75 | */ |
||
| 76 | protected $ID_RateCode = null; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * @param int $ID_Account |
||
| 80 | * @param int $AccountNo |
||
| 81 | * @param string $RoomNo |
||
| 82 | * @param string $AccountName |
||
| 83 | * @param int $ID_RoomType |
||
| 84 | * @param string $RoomTypeName |
||
| 85 | * @param int $RoomQty |
||
| 86 | * @param int $GuestTotal |
||
| 87 | * @param \DateTime $ArrivalDate |
||
| 88 | * @param \DateTime $DepartureDate |
||
| 89 | * @param int $ID_Group |
||
| 90 | * @param int $AccountStatus |
||
| 91 | * @param string $AccountStatusString |
||
| 92 | * @param string $ID_RateCode |
||
| 93 | */ |
||
| 94 | View Code Duplication | public function __construct($ID_Account, $AccountNo, $RoomNo, $AccountName, $ID_RoomType, $RoomTypeName, $RoomQty, $GuestTotal, \DateTime $ArrivalDate, \DateTime $DepartureDate, $ID_Group, $AccountStatus, $AccountStatusString, $ID_RateCode) |
|
| 111 | |||
| 112 | /** |
||
| 113 | * @return int |
||
| 114 | */ |
||
| 115 | public function getID_Account() |
||
| 119 | |||
| 120 | /** |
||
| 121 | * @param int $ID_Account |
||
| 122 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 123 | */ |
||
| 124 | public function setID_Account($ID_Account) |
||
| 129 | |||
| 130 | /** |
||
| 131 | * @return int |
||
| 132 | */ |
||
| 133 | public function getAccountNo() |
||
| 137 | |||
| 138 | /** |
||
| 139 | * @param int $AccountNo |
||
| 140 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 141 | */ |
||
| 142 | public function setAccountNo($AccountNo) |
||
| 147 | |||
| 148 | /** |
||
| 149 | * @return string |
||
| 150 | */ |
||
| 151 | public function getRoomNo() |
||
| 155 | |||
| 156 | /** |
||
| 157 | * @param string $RoomNo |
||
| 158 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 159 | */ |
||
| 160 | public function setRoomNo($RoomNo) |
||
| 165 | |||
| 166 | /** |
||
| 167 | * @return string |
||
| 168 | */ |
||
| 169 | public function getAccountName() |
||
| 173 | |||
| 174 | /** |
||
| 175 | * @param string $AccountName |
||
| 176 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 177 | */ |
||
| 178 | public function setAccountName($AccountName) |
||
| 183 | |||
| 184 | /** |
||
| 185 | * @return int |
||
| 186 | */ |
||
| 187 | public function getID_RoomType() |
||
| 191 | |||
| 192 | /** |
||
| 193 | * @param int $ID_RoomType |
||
| 194 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 195 | */ |
||
| 196 | public function setID_RoomType($ID_RoomType) |
||
| 201 | |||
| 202 | /** |
||
| 203 | * @return string |
||
| 204 | */ |
||
| 205 | public function getRoomTypeName() |
||
| 209 | |||
| 210 | /** |
||
| 211 | * @param string $RoomTypeName |
||
| 212 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 213 | */ |
||
| 214 | public function setRoomTypeName($RoomTypeName) |
||
| 219 | |||
| 220 | /** |
||
| 221 | * @return int |
||
| 222 | */ |
||
| 223 | public function getRoomQty() |
||
| 227 | |||
| 228 | /** |
||
| 229 | * @param int $RoomQty |
||
| 230 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 231 | */ |
||
| 232 | public function setRoomQty($RoomQty) |
||
| 237 | |||
| 238 | /** |
||
| 239 | * @return int |
||
| 240 | */ |
||
| 241 | public function getGuestTotal() |
||
| 245 | |||
| 246 | /** |
||
| 247 | * @param int $GuestTotal |
||
| 248 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 249 | */ |
||
| 250 | public function setGuestTotal($GuestTotal) |
||
| 255 | |||
| 256 | /** |
||
| 257 | * @return \DateTime |
||
| 258 | */ |
||
| 259 | public function getArrivalDate() |
||
| 271 | |||
| 272 | /** |
||
| 273 | * @param \DateTime $ArrivalDate |
||
| 274 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 275 | */ |
||
| 276 | public function setArrivalDate(\DateTime $ArrivalDate) |
||
| 281 | |||
| 282 | /** |
||
| 283 | * @return \DateTime |
||
| 284 | */ |
||
| 285 | public function getDepartureDate() |
||
| 297 | |||
| 298 | /** |
||
| 299 | * @param \DateTime $DepartureDate |
||
| 300 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 301 | */ |
||
| 302 | public function setDepartureDate(\DateTime $DepartureDate) |
||
| 307 | |||
| 308 | /** |
||
| 309 | * @return int |
||
| 310 | */ |
||
| 311 | public function getID_Group() |
||
| 315 | |||
| 316 | /** |
||
| 317 | * @param int $ID_Group |
||
| 318 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 319 | */ |
||
| 320 | public function setID_Group($ID_Group) |
||
| 325 | |||
| 326 | /** |
||
| 327 | * @return int |
||
| 328 | */ |
||
| 329 | public function getAccountStatus() |
||
| 333 | |||
| 334 | /** |
||
| 335 | * @param int $AccountStatus |
||
| 336 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 337 | */ |
||
| 338 | public function setAccountStatus($AccountStatus) |
||
| 343 | |||
| 344 | /** |
||
| 345 | * @return string |
||
| 346 | */ |
||
| 347 | public function getAccountStatusString() |
||
| 351 | |||
| 352 | /** |
||
| 353 | * @param string $AccountStatusString |
||
| 354 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 355 | */ |
||
| 356 | public function setAccountStatusString($AccountStatusString) |
||
| 361 | |||
| 362 | /** |
||
| 363 | * @return string |
||
| 364 | */ |
||
| 365 | public function getID_RateCode() |
||
| 369 | |||
| 370 | /** |
||
| 371 | * @param string $ID_RateCode |
||
| 372 | * @return \Gueststream\PMS\IQWare\API\GroupReservations |
||
| 373 | */ |
||
| 374 | public function setID_RateCode($ID_RateCode) |
||
| 379 | } |
||
| 380 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.