Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class GetServiceCharges |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $intGUID |
||
| 10 | */ |
||
| 11 | protected $intGUID = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $strServiceChargeIDs |
||
| 15 | */ |
||
| 16 | protected $strServiceChargeIDs = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $strRoomTypeIDs |
||
| 20 | */ |
||
| 21 | protected $strRoomTypeIDs = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @var \DateTime $dtBeginDate |
||
| 25 | */ |
||
| 26 | protected $dtBeginDate = null; |
||
| 27 | |||
| 28 | /** |
||
| 29 | * @var \DateTime $dtEndDate |
||
| 30 | */ |
||
| 31 | protected $dtEndDate = null; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var ArrayOfStayValue3 $StayValueArray |
||
| 35 | */ |
||
| 36 | protected $StayValueArray = null; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * @param int $intGUID |
||
| 40 | * @param string $strServiceChargeIDs |
||
| 41 | * @param string $strRoomTypeIDs |
||
| 42 | * @param \DateTime $dtBeginDate |
||
| 43 | * @param \DateTime $dtEndDate |
||
| 44 | * @param ArrayOfStayValue3 $StayValueArray |
||
| 45 | */ |
||
| 46 | public function __construct($intGUID, $strServiceChargeIDs, $strRoomTypeIDs, \DateTime $dtBeginDate, \DateTime $dtEndDate, $StayValueArray) |
||
| 55 | |||
| 56 | /** |
||
| 57 | * @return int |
||
| 58 | */ |
||
| 59 | public function getIntGUID() |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @param int $intGUID |
||
| 66 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 67 | */ |
||
| 68 | public function setIntGUID($intGUID) |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @return string |
||
| 76 | */ |
||
| 77 | public function getStrServiceChargeIDs() |
||
| 81 | |||
| 82 | /** |
||
| 83 | * @param string $strServiceChargeIDs |
||
| 84 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 85 | */ |
||
| 86 | public function setStrServiceChargeIDs($strServiceChargeIDs) |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @return string |
||
| 94 | */ |
||
| 95 | public function getStrRoomTypeIDs() |
||
| 99 | |||
| 100 | /** |
||
| 101 | * @param string $strRoomTypeIDs |
||
| 102 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 103 | */ |
||
| 104 | public function setStrRoomTypeIDs($strRoomTypeIDs) |
||
| 109 | |||
| 110 | /** |
||
| 111 | * @return \DateTime |
||
| 112 | */ |
||
| 113 | public function getDtBeginDate() |
||
| 125 | |||
| 126 | /** |
||
| 127 | * @param \DateTime $dtBeginDate |
||
| 128 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 129 | */ |
||
| 130 | public function setDtBeginDate(\DateTime $dtBeginDate) |
||
| 135 | |||
| 136 | /** |
||
| 137 | * @return \DateTime |
||
| 138 | */ |
||
| 139 | public function getDtEndDate() |
||
| 151 | |||
| 152 | /** |
||
| 153 | * @param \DateTime $dtEndDate |
||
| 154 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 155 | */ |
||
| 156 | public function setDtEndDate(\DateTime $dtEndDate) |
||
| 161 | |||
| 162 | /** |
||
| 163 | * @return ArrayOfStayValue3 |
||
| 164 | */ |
||
| 165 | public function getStayValueArray() |
||
| 169 | |||
| 170 | /** |
||
| 171 | * @param ArrayOfStayValue3 $StayValueArray |
||
| 172 | * @return \Gueststream\PMS\IQWare\API\GetServiceCharges |
||
| 173 | */ |
||
| 174 | public function setStayValueArray($StayValueArray) |
||
| 179 | } |
||
| 180 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.