Gueststream-Inc /
iqware
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class Bedding |
|
|
|
|||
| 6 | { |
||
| 7 | |||
| 8 | /** |
||
| 9 | * @var int $ID_Bedding |
||
| 10 | */ |
||
| 11 | protected $ID_Bedding = null; |
||
| 12 | |||
| 13 | /** |
||
| 14 | * @var string $Name |
||
| 15 | */ |
||
| 16 | protected $Name = null; |
||
| 17 | |||
| 18 | /** |
||
| 19 | * @var string $ShortName |
||
| 20 | */ |
||
| 21 | protected $ShortName = null; |
||
| 22 | |||
| 23 | /** |
||
| 24 | * @param int $ID_Bedding |
||
| 25 | */ |
||
| 26 | public function __construct($ID_Bedding) |
||
| 30 | |||
| 31 | /** |
||
| 32 | * @return int |
||
| 33 | */ |
||
| 34 | public function getID_Bedding() |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @param int $ID_Bedding |
||
| 41 | * @return \Gueststream\PMS\IQWare\API\Bedding |
||
| 42 | */ |
||
| 43 | public function setID_Bedding($ID_Bedding) |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @return string |
||
| 51 | */ |
||
| 52 | public function getName() |
||
| 56 | |||
| 57 | /** |
||
| 58 | * @param string $Name |
||
| 59 | * @return \Gueststream\PMS\IQWare\API\Bedding |
||
| 60 | */ |
||
| 61 | public function setName($Name) |
||
| 66 | |||
| 67 | /** |
||
| 68 | * @return string |
||
| 69 | */ |
||
| 70 | public function getShortName() |
||
| 74 | |||
| 75 | /** |
||
| 76 | * @param string $ShortName |
||
| 77 | * @return \Gueststream\PMS\IQWare\API\Bedding |
||
| 78 | */ |
||
| 79 | public function setShortName($ShortName) |
||
| 84 | } |
||
| 85 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.