Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
5 | View Code Duplication | class ArrayOfInt implements \ArrayAccess, \Iterator, \Countable |
|
|
|||
6 | { |
||
7 | |||
8 | /** |
||
9 | * @var int[] $int |
||
10 | */ |
||
11 | protected $int = null; |
||
12 | |||
13 | |||
14 | public function __construct() |
||
18 | |||
19 | /** |
||
20 | * @return int[] |
||
21 | */ |
||
22 | public function getInt() |
||
26 | |||
27 | /** |
||
28 | * @param int[] $int |
||
29 | * @return \Gueststream\PMS\IQWare\API\ArrayOfInt |
||
30 | */ |
||
31 | public function setInt(array $int = null) |
||
36 | |||
37 | /** |
||
38 | * ArrayAccess implementation |
||
39 | * |
||
40 | * @param mixed $offset An offset to check for |
||
41 | * @return boolean true on success or false on failure |
||
42 | */ |
||
43 | public function offsetExists($offset) |
||
47 | |||
48 | /** |
||
49 | * ArrayAccess implementation |
||
50 | * |
||
51 | * @param mixed $offset The offset to retrieve |
||
52 | * @return int |
||
53 | */ |
||
54 | public function offsetGet($offset) |
||
58 | |||
59 | /** |
||
60 | * ArrayAccess implementation |
||
61 | * |
||
62 | * @param mixed $offset The offset to assign the value to |
||
63 | * @param int $value The value to set |
||
64 | * @return void |
||
65 | */ |
||
66 | public function offsetSet($offset, $value) |
||
70 | |||
71 | /** |
||
72 | * ArrayAccess implementation |
||
73 | * |
||
74 | * @param mixed $offset The offset to unset |
||
75 | * @return void |
||
76 | */ |
||
77 | public function offsetUnset($offset) |
||
81 | |||
82 | /** |
||
83 | * Iterator implementation |
||
84 | * |
||
85 | * @return int Return the current element |
||
86 | */ |
||
87 | public function current() |
||
91 | |||
92 | /** |
||
93 | * Iterator implementation |
||
94 | * Move forward to next element |
||
95 | * |
||
96 | * @return void |
||
97 | */ |
||
98 | public function next() |
||
102 | |||
103 | /** |
||
104 | * Iterator implementation |
||
105 | * |
||
106 | * @return string|null Return the key of the current element or null |
||
107 | */ |
||
108 | public function key() |
||
112 | |||
113 | /** |
||
114 | * Iterator implementation |
||
115 | * |
||
116 | * @return boolean Return the validity of the current position |
||
117 | */ |
||
118 | public function valid() |
||
122 | |||
123 | /** |
||
124 | * Iterator implementation |
||
125 | * Rewind the Iterator to the first element |
||
126 | * |
||
127 | * @return void |
||
128 | */ |
||
129 | public function rewind() |
||
133 | |||
134 | /** |
||
135 | * Countable implementation |
||
136 | * |
||
137 | * @return int Return count of elements |
||
138 | */ |
||
139 | public function count() |
||
143 | } |
||
144 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.