GroganBurners / ferveo

app.js

const config = require('./config')
const express = require('express')
const path = require('path')
const logger = require('./config/logger')
const morgan = require('morgan')
const session = require('express-session')
const cookieParser = require('cookie-parser')
const methodOverride = require('method-override')
const bodyParser = require('body-parser')
const flash = require('connect-flash')
const mongoose = require('mongoose')

const app = express()

require('./models')(app)

/**
 * API keys and Passport configuration.
 */
const passport = require('passport')
require('./config/passport')

// connect to Mongo when the app initializes
mongoose.connect(config.db)

// view engine setup
app.set('views', path.join(__dirname, 'views'))
app.set('view engine', 'pug')

// uncomment after placing your favicon in /public
// app.use(favicon(path.join(__dirname, 'public', 'favicon.ico')));
if (config.env === 'development') {
  app.use(morgan('dev', { stream: { write: message => logger.info(message) } }))
} else {
  app.use(morgan('combined', { stream: { write: message => logger.info(message) } }))
}
app.use(bodyParser.json())
app.use(bodyParser.urlencoded({ extended: true }))
app.use(methodOverride(function(req, res){

The parameter res is not used and could be removed.

      if (req.body && typeof req.body === 'object' && '_method' in req.body) {

There is no return statement if req.body && typeof req.body === "object" && "_method" in req.body is false. Are you sure this is correct? If so, consider adding return; explicitly.

        logger.info('In method override')
        // look in urlencoded POST bodies and delete it
        var method = req.body._method
        delete req.body._method
        return method
      }
}))
app.use(cookieParser())
app.use(session({
  secret: config.cookieSecret,
  name: config.sessionName,
  proxy: true,
  resave: true,
  saveUninitialized: true
}))
app.use(flash())
app.use('/static', express.static(path.join(__dirname, 'public')))
app.use(passport.initialize())
app.use(passport.session())
require('./config/routes')(app)

// catch 404 and forward to error handler
app.use(function (req, res, next) {
  var err = new Error('Not Found')
  err.status = 404
  next(err)
})

// error handler
app.use(function (err, req, res, next) {

The parameter next is not used and could be removed.

  // set locals, only providing error in development
  res.locals.message = err.message
  res.locals.error = req.app.get('env') === 'development' ? err : {}
  logger.error(err.stack)
  // render the error page
  res.status(err.status || 500)
  res.render('error')
})

module.exports = app