Curly braces around statements make for more readable code and help prevent bugs when you add further statements.
Consider adding curly braces around all statements when they are executed conditionally.
This is optional if there is only one statement, but leaving them out can lead to unexpected
behaviour if another statement is added later.
Consider:
if(a>0)b=42;
If you or someone else later decides to put another statement in, only the first
statement will be executed.
if(a>0)console.log("a > 0");b=42;
In this case the statement b=42 will always be executed, while
the logging statement will be executed conditionally.
if(a>0){console.log("a > 0");b=42;}
ensures that the proper code will be executed conditionally no matter how
many statements are added or removed.
There is no return statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding return undefined; explicitly.
Loading history...
35
}
36
})
37
}
38
39
module.exports.respondOrRedirect = function respondOrRedirect ({ req, res }, url = '/', obj = {}, flash) {
40
res.format({
41
html: () => {
42
if (req && flash) req.flash(flash.type, flash.text)
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.
Consider adding curly braces around all statements when they are executed conditionally.
This is optional if there is only one statement, but leaving them out can lead to unexpected
behaviour if another statement is added later.
Consider:
if(a>0)b=42;
If you or someone else later decides to put another statement in, only the first
statement will be executed.
if(a>0)console.log("a > 0");b=42;
In this case the statement b=42 will always be executed, while
the logging statement will be executed conditionally.
if(a>0){console.log("a > 0");b=42;}
ensures that the proper code will be executed conditionally no matter how
many statements are added or removed.
GroganBurners /
ferveo
Loading history...
Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.
Consider:
If you or someone else later decides to put another statement in, only the first statement will be executed.
In this case the statement
b = 42will always be executed, while the logging statement will be executed conditionally.ensures that the proper code will be executed conditionally no matter how many statements are added or removed.