Queue - Code Metrics - Inspection of "style(删除修改的代码):" - Graychen/yii2-queue-backend - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by graychen

created 2017-11-13 02:40 UTC

Queue A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

73.08%

Importance

Changes

Metric	Value
wmc	9
lcom	0
cbo	3
dl	0
loc	68
ccs	19
cts	26
cp	0.7308
rs	10
c	0
b	0
f	0

6 Methods

Rating	Name	Size	Complexity
A	tableName()	4	1
A	getExecutionTime()	4	1
A	behaviors()	8	1
A	rules()	6	1
A	attributeLabels()	15	1
A	getStatus()	11	4

<?php
namespace graychen\yii2\queue\backend\models;

use Yii;
use yii\behaviors\TimestampBehavior;
use yii\db\ActiveRecord;

class Queue extends ActiveRecord
{
    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%queue}}';
    }

    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'timestamp' => [
                'class' => TimestampBehavior::className(),
            ]
        ];
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['queue_id', 'catalog', 'name', 'description'], 'required']
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app/queue', 'ID'),
            'queue_id' => Yii::t('app/queue', '队列id'),
            'catalog' => Yii::t('app/queue', '类别'),
            'name' => Yii::t('app/queue', '任务名称'),
            'description' => Yii::t('app/queue', '详请信息'),
            'exec_time' => Yii::t('app/queue', '执行时间'),
            'status' => Yii::t('app/queue', '状态'),
            'created_at' => Yii::t('app/queue', '队列创建时间'),
            'updated_at' => Yii::t('app/queue', '队列修改时间'),
            'execution_time' => Yii::t('app/queue', '队列执行时间')
        ];
    }

    public function getExecutionTime()
    {
        return $this->exec_time+$this->created_at;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function getStatus($id)
    {
        if (Yii::$app->queue->isWaiting($id) || Yii::$app->queue->isReserved($id)) {
            $status=0;
        } elseif (Yii::$app->queue->isDone($id)) {
            $status=1;
        } else {
            $status=-1;
        }
        return $status;
    }
}


1		<?php
2		namespace graychen\yii2\queue\backend\models;
3
4		use Yii;
5		use yii\behaviors\TimestampBehavior;
6		use yii\db\ActiveRecord;
7
8		class Queue extends ActiveRecord
9		{
10		/**
11		* @inheritdoc
12		*/
13	2	public static function tableName()
14		{
15	2	return '{{%queue}}';
16		}
17
18		/**
19		* @inheritdoc
20		*/
21	4	public function behaviors()
22		{
23		return [
24		'timestamp' => [
25	4	'class' => TimestampBehavior::className(),
26		]
27		];
28		}
29
30		/**
31		* @inheritdoc
32		*/
33	1	public function rules()
34		{
35		return [
36	1	[['queue_id', 'catalog', 'name', 'description'], 'required']
37		];
38		}
39
40		/**
41		* @inheritdoc
42		*/
43	1	public function attributeLabels()
44		{
45		return [
46	1	'id' => Yii::t('app/queue', 'ID'),
47	1	'queue_id' => Yii::t('app/queue', '队列id'),
48	1	'catalog' => Yii::t('app/queue', '类别'),
49	1	'name' => Yii::t('app/queue', '任务名称'),
50	1	'description' => Yii::t('app/queue', '详请信息'),
51	1	'exec_time' => Yii::t('app/queue', '执行时间'),
52	1	'status' => Yii::t('app/queue', '状态'),
53	1	'created_at' => Yii::t('app/queue', '队列创建时间'),
54	1	'updated_at' => Yii::t('app/queue', '队列修改时间'),
55	1	'execution_time' => Yii::t('app/queue', '队列执行时间')
56		];
57		}
58
59	1	public function getExecutionTime()
60		{
61	1	return $this->exec_time+$this->created_at;
		0 ignored issues – show Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `exec_time` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `created_at` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
62		}
63
64		public function getStatus($id)
65		{
66		if (Yii::$app->queue->isWaiting($id) \|\| Yii::$app->queue->isReserved($id)) {
67		$status=0;
68		} elseif (Yii::$app->queue->isDone($id)) {
69		$status=1;
70		} else {
71		$status=-1;
72		}
73		return $status;
74		}
75		}
76

Graychen / yii2-queue-backend

Pull Request — master (#10)

Queue A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

6 Methods

Duplication Side-by-Side

Filter issues like