Job - Code Metrics - Graychen/yii2-queue-backend - Measure and Improve Code Quality continuously with Scrutinizer

Job A
last analyzed 2018-08-08 09:32 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	3
dl	0
loc	40
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
	getName()	1	?
	getCatalog()	1	?
	getDescription()	1	?
A	init()	22	3

<?php

namespace graychen\yii2\queue\backend\jobs;

use yii\base\BaseObject;
use yii;
use yii\queue\Queue;
use graychen\yii2\queue\backend\models\Queue as QueueDb;

abstract class Job extends BaseObject implements JobInterface
{
    public function init()
    {
        parent::init();
        Yii::$app->queue->on(Queue::EVENT_AFTER_PUSH, function ($event) {
            $delay=$event->delay>=0 ?$event->delay : 0;
            $queue = new QueueDb();
            $queue->name=$this->getName();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $queue->catalog=$this->getCatalog();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $queue->description=$this->getDescription();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $queue->exec_time=$delay + time();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $queue->queue_id=$event->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $queue->save();
        });
        //增加错误日志
        Yii::$app->queue->on(Queue::EVENT_AFTER_ERROR, function (ErrorEvent $event) {
            if ($event->job instanceof \graychen\yii2\queue\backend\jobs\ BaseObject) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                $model = Queue::findOne(['queue_id'=>$event->id]);

                $model->log = $event->error;
                $model->save();
            }
        });
    }

    /** name (任务名称)
     * @return string
     */
    abstract public function getName();

    /** catalog (类别: 推送任务, 上传报告)
     * @return string
     */
    abstract public function getCatalog();

    /** description (队列详情)
     * @return string
     */
    abstract public function getDescription();
}


Job A
last analyzed 2018-08-08 09:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

1. Missing dependencies

2. Missing use statement

1			<?php
2
3			namespace graychen\yii2\queue\backend\jobs;
4
5			use yii\base\BaseObject;
6			use yii;
7			use yii\queue\Queue;
8			use graychen\yii2\queue\backend\models\Queue as QueueDb;
9
10			abstract class Job extends BaseObject implements JobInterface
11			{
12			public function init()
13			{
14			parent::init();
15			Yii::$app->queue->on(Queue::EVENT_AFTER_PUSH, function ($event) {
16			$delay=$event->delay>=0 ?$event->delay : 0;
17			$queue = new QueueDb();
18			$queue->name=$this->getName();
			0 ignored issues – show Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `name` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
19			$queue->catalog=$this->getCatalog();
			0 ignored issues – show Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `catalog` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
20			$queue->description=$this->getDescription();
			0 ignored issues – show Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `description` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
21			$queue->exec_time=$delay + time();
			0 ignored issues – show Documentation introduced 2017-11-13 09:45 UTC by Report Bug Copy Issue Report The property `exec_time` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
22			$queue->queue_id=$event->id;
			0 ignored issues – show Documentation introduced 2017-11-10 05:20 UTC by Report Bug Copy Issue Report The property `queue_id` does not exist on `object<graychen\yii2\queue\backend\models\Queue>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
23			$queue->save();
24			});
25			//增加错误日志
26			Yii::$app->queue->on(Queue::EVENT_AFTER_ERROR, function (ErrorEvent $event) {
27			if ($event->job instanceof \graychen\yii2\queue\backend\jobs\ BaseObject) {
			0 ignored issues – show Bug introduced 2018-03-28 09:34 UTC by Report Bug Copy Issue Report The class `graychen\yii2\queue\backend\jobs\BaseObject` does not exist. Did you forget a USE statement, or did you not list all dependencies? This error could be the result of: 1. Missing dependencies PHP Analyzer uses your `composer.json` file (if available) to determine the dependencies of your project and to determine all the available classes and functions. It expects the `composer.json` to be in the root folder of your repository. Are you sure this class is defined by one of your dependencies, or did you maybe not list a dependency in either the `require` or `require-dev` section? 2. Missing use statement PHP does not complain about undefined classes in `ìnstanceof` checks. For example, the following PHP code will work perfectly fine: if ($x instanceof DoesNotExist) { // Do something. } If you have not tested against this specific condition, such errors might go unnoticed. Loading history...
28			$model = Queue::findOne(['queue_id'=>$event->id]);
			0 ignored issues – show Bug introduced 2018-03-28 09:34 UTC by Report Bug Copy Issue Report The method `findOne()` does not seem to exist on `object<yii\queue\Queue>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
29			$model->log = $event->error;
30			$model->save();
31			}
32			});
33			}
34
35			/** name (任务名称)
36			* @return string
37			*/
38			abstract public function getName();
39
40			/** catalog (类别: 推送任务, 上传报告)
41			* @return string
42			*/
43			abstract public function getCatalog();
44
45			/** description (队列详情)
46			* @return string
47			*/
48			abstract public function getDescription();
49			}
50

Graychen / yii2-queue-backend

Job A last analyzed 2018-08-08 09:32 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like

Job A
last analyzed 2018-08-08 09:32 UTC