GravityMedia\Uri\AbstractQuery

Complexity

Total Complexity

14

Size/Duplication

Total Lines	133
Duplicated Lines	12.03 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

9 Methods

Rating	Name	Duplication	Size	Complexity
A	fromArray()	0	9	2
A	fromString()	0	7	1
A	__set()	7	7	2
A	__get()	9	9	2
A	__isset()	0	9	2
A	__unset()	0	4	1
A	__toString()	0	4	1
A	toString()	0	4	1
A	toArray()	0	15	2

<?php
/**
 * This file is part of the Uri package.
 *
 * @author Daniel Schröder <daniel.schroeder@gravitymedia.de>
 */

namespace GravityMedia\Uri;

/**
 * Abstract query component class.
 *
 * @package GravityMedia\Uri
 */
abstract class AbstractQuery
{
    /**
     * Create query object from array.
     *
     * @param array $array
     *
     * @return static
     */
    public static function fromArray(array $array = [])
    {
        $query = new static();
        foreach ($array as $argument => $value) {
            $query->__set($argument, $value);
        }

        return $query;
    }

    /**
     * Create query object from string.
     *
     * @param string $string
     *
     * @return static
     */
    public static function fromString($string)
    {
        $array = [];
        parse_str($string, $array);

        return static::fromArray($array);

It seems like $array can also be of type null; however, GravityMedia\Uri\AbstractQuery::fromArray() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Set a query argument.
     *
     * @param string $argument
     * @param mixed  $value
     */
    public function __set($argument, $value)

This method seems to be duplicated in your project.

    {
        $setter = 'set' . str_replace('_', '', $argument);
        if (is_callable([$this, $setter])) {
            call_user_func([$this, $setter], $value);
        }
    }

    /**
     * Get a query argument.
     *
     * @param string $argument
     *
     * @return mixed
     */
    public function __get($argument)

This method seems to be duplicated in your project.

    {
        $getter = 'get' . str_replace('_', '', $argument);
        if (is_callable([$this, $getter])) {
            return call_user_func([$this, $getter]);
        }

        return null;
    }

    /**
     * Test if a query argument is NULL.
     *
     * @param string $argument
     *
     * @return bool
     */
    public function __isset($argument)
    {
        $getter = 'get' . str_replace('_', '', $argument);
        if (!method_exists($this, $getter)) {
            return false;
        }

        return null !== $this->__get($argument);
    }

    /**
     * Set a query argument to NULL.
     *
     * @param string $argument
     */
    public function __unset($argument)
    {
        $this->__set($argument, null);
    }

    /**
     * Return string representation.
     *
     * @return string
     */
    public function __toString()
    {
        return $this->toString();
    }

    /**
     * Convert query into a string representation.
     *
     * @return string
     */
    public function toString()
    {
        return http_build_query($this->toArray());
    }

    /**
     * Convert query into a array representation.
     *
     * @return array
     */
    public function toArray()
    {
        $array = [];
        foreach ($this as $argument => $value) {

The expression $this of type this<GravityMedia\Uri\AbstractQuery> is not traversable.

            $normalizedArgument = preg_replace_callback('/([A-Z])/', function ($letters) {
                $letter = array_shift($letters);

                return '_' . strtolower($letter);
            }, $argument);

            $array[$normalizedArgument] = $value;
        }

        return $array;
    }
}