Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
28 | class FrameReader |
||
29 | { |
||
30 | /** |
||
31 | * @var StreamInterface |
||
32 | */ |
||
33 | protected $stream; |
||
34 | |||
35 | /** |
||
36 | * @var HeaderInterface |
||
37 | */ |
||
38 | protected $header; |
||
39 | |||
40 | /** |
||
41 | * @var Integer16Reader |
||
42 | */ |
||
43 | protected $integer16Reader; |
||
44 | |||
45 | /** |
||
46 | * @var Integer24Reader |
||
47 | */ |
||
48 | protected $integer24Reader; |
||
49 | |||
50 | /** |
||
51 | * @var Integer32Reader |
||
52 | */ |
||
53 | protected $integer32Reader; |
||
54 | |||
55 | /** |
||
56 | * @var SynchsafeInteger32Reader |
||
57 | */ |
||
58 | protected $synchsafeInteger32Reader; |
||
59 | |||
60 | /** |
||
61 | * Create ID3v2 frame reader. |
||
62 | * |
||
63 | * @param StreamInterface $stream |
||
64 | * @param HeaderInterface $header |
||
65 | */ |
||
66 | public function __construct(StreamInterface $stream, HeaderInterface $header) |
||
71 | |||
72 | /** |
||
73 | * Get 16-bit integer reader |
||
74 | * |
||
75 | * @return Integer16Reader |
||
76 | */ |
||
77 | View Code Duplication | public function getInteger16Reader() |
|
86 | |||
87 | /** |
||
88 | * Get 24-bit integer reader |
||
89 | * |
||
90 | * @return Integer24Reader |
||
91 | */ |
||
92 | View Code Duplication | public function getInteger24Reader() |
|
101 | |||
102 | /** |
||
103 | * Get 32-bit integer reader |
||
104 | * |
||
105 | * @return Integer32Reader |
||
106 | */ |
||
107 | View Code Duplication | public function getInteger32Reader() |
|
116 | |||
117 | /** |
||
118 | * Get synchsafe 32-bit integer reader |
||
119 | * |
||
120 | * @return SynchsafeInteger32Reader |
||
121 | */ |
||
122 | View Code Duplication | public function getSynchsafeInteger32Reader() |
|
131 | |||
132 | /** |
||
133 | * Read ID3v2 frame name. |
||
134 | * |
||
135 | * @return string |
||
136 | */ |
||
137 | protected function readName() |
||
145 | |||
146 | /** |
||
147 | * Read ID3v2 frame size. |
||
148 | * |
||
149 | * @return int |
||
150 | */ |
||
151 | protected function readSize() |
||
163 | |||
164 | /** |
||
165 | * Read ID3v2 frame flags. |
||
166 | * |
||
167 | * @return array |
||
168 | */ |
||
169 | protected function readFlags() |
||
195 | |||
196 | /** |
||
197 | * Read ID3v2 frame data length. |
||
198 | * |
||
199 | * @return int |
||
200 | */ |
||
201 | public function readDataLength() |
||
205 | |||
206 | /** |
||
207 | * Read ID3v2 frame. |
||
208 | * |
||
209 | * @return FrameInterface |
||
210 | */ |
||
211 | public function read() |
||
252 | } |
||
253 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.