Tag::getYear() - Code Metrics - Inspection of "Moved some interfaces and fixed Travis file" - GravityMedia/Metadata - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — id3-metadata-objects ( 161f4c...a3a88a )

by Daniel

created 2016-03-30 11:35 UTC

Tag::getYear() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	1
nc	1
nop	0

<?php
/**
 * This file is part of the Metadata package.
 *
 * @author Daniel Schröder <[email protected]>
 */

namespace GravityMedia\Metadata\ID3v2;

use GravityMedia\Metadata\Exception\BadMethodCallException;
use GravityMedia\Metadata\ID3v2\Enum\Version;

/**
 * ID3v2 tag
 *
 * @package GravityMedia\Metadata\ID3v2
 */
class Tag implements TagInterface
{
    /**
     * @var HeaderInterface
     */
    protected $header;

    /**
     * @var ExtendedHeader
     */
    protected $extendedHeader;

    /**
     * @var FrameInterface[]
     */
    protected $frames;

    /**
     * Create tag object.
     *
     * @param HeaderInterface $header
     */
    public function __construct(HeaderInterface $header)
    {
        $this->header = $header;
        $this->frames = new \ArrayObject();

    }

    /**
     * Get header
     *
     * @return HeaderInterface
     */
    public function getHeader()
    {
        return $this->header;
    }

    /**
     * Get extended header
     *
     * @return ExtendedHeader
     */
    public function getExtendedHeader()
    {
        return $this->extendedHeader;
    }

    /**
     * Set extended header
     *
     * @param ExtendedHeaderInterface $extendedHeader
     *
     * @throws BadMethodCallException An exception is thrown on ID3 v2.2 tag
     *
     * @return $this
     */
    public function setExtendedHeader(ExtendedHeaderInterface $extendedHeader)
    {
        if (!in_array($this->getVersion(), [Version::VERSION_23, Version::VERSION_24])) {
            throw new BadMethodCallException('Extended header is not supported in this version.');
        }

        $this->extendedHeader = $extendedHeader;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getVersion()
    {
        return $this->header->getVersion();
    }

    /**
     * {@inheritdoc}
     */
    public function getFrames()
    {
        return $this->frames;
    }

    /**
     * Add frame
     *
     * @param FrameInterface $frame
     *
     * @return $this
     */
    public function addFrame(FrameInterface $frame)
    {
        $this->frames->append($frame);

        return $this;
    }
}


1			<?php
2			/**
3			* This file is part of the Metadata package.
4			*
5			* @author Daniel Schröder <[email protected]>
6			*/
7
8			namespace GravityMedia\Metadata\ID3v2;
9
10			use GravityMedia\Metadata\Exception\BadMethodCallException;
11			use GravityMedia\Metadata\ID3v2\Enum\Version;
12
13			/**
14			* ID3v2 tag
15			*
16			* @package GravityMedia\Metadata\ID3v2
17			*/
18			class Tag implements TagInterface
19			{
20			/**
21			* @var HeaderInterface
22			*/
23			protected $header;
24
25			/**
26			* @var ExtendedHeader
27			*/
28			protected $extendedHeader;
29
30			/**
31			* @var FrameInterface[]
32			*/
33			protected $frames;
34
35			/**
36			* Create tag object.
37			*
38			* @param HeaderInterface $header
39			*/
40			public function __construct(HeaderInterface $header)
41			{
42			$this->header = $header;
43			$this->frames = new \ArrayObject();
			0 ignored issues – show Documentation Bug introduced 2016-03-30 11:38 UTC by Report Bug Copy Issue Report It seems like `new \ArrayObject()` of type `object<ArrayObject>` is incompatible with the declared type `array<integer,object<Gra...\ID3v2\FrameInterface>>` of property `$frames`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
44			}
45
46			/**
47			* Get header
48			*
49			* @return HeaderInterface
50			*/
51			public function getHeader()
52			{
53			return $this->header;
54			}
55
56			/**
57			* Get extended header
58			*
59			* @return ExtendedHeader
60			*/
61			public function getExtendedHeader()
62			{
63			return $this->extendedHeader;
64			}
65
66			/**
67			* Set extended header
68			*
69			* @param ExtendedHeaderInterface $extendedHeader
70			*
71			* @throws BadMethodCallException An exception is thrown on ID3 v2.2 tag
72			*
73			* @return $this
74			*/
75			public function setExtendedHeader(ExtendedHeaderInterface $extendedHeader)
76			{
77			if (!in_array($this->getVersion(), [Version::VERSION_23, Version::VERSION_24])) {
78			throw new BadMethodCallException('Extended header is not supported in this version.');
79			}
80
81			$this->extendedHeader = $extendedHeader;
			0 ignored issues – show Documentation Bug introduced 2016-03-30 11:38 UTC by Report Bug Copy Issue Report `$extendedHeader` is of type `object<GravityMedia\Meta...xtendedHeaderInterface>`, but the property `$extendedHeader` was declared to be of type `object<GravityMedia\Meta...a\ID3v2\ExtendedHeader>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
82
83			return $this;
84			}
85
86			/**
87			* {@inheritdoc}
88			*/
89			public function getVersion()
90			{
91			return $this->header->getVersion();
92			}
93
94			/**
95			* {@inheritdoc}
96			*/
97			public function getFrames()
98			{
99			return $this->frames;
100			}
101
102			/**
103			* Add frame
104			*
105			* @param FrameInterface $frame
106			*
107			* @return $this
108			*/
109			public function addFrame(FrameInterface $frame)
110			{
111			$this->frames->append($frame);
			0 ignored issues – show Bug introduced 2016-03-30 11:38 UTC by Report Bug Copy Issue Report The method `append` cannot be called on `$this->frames` (of type `array<integer,object<Gra...\ID3v2\FrameInterface>>`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
112			return $this;
113			}
114			}
115

GravityMedia / Metadata

Push — id3-metadata-objects ( 161f4c...a3a88a )

Tag::getYear() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like