GravityMedia\Metadata\ID3v2\Tag

Complexity

Total Complexity

8

Size/Duplication

Total Lines	97
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	2

Importance

Changes	8
Bugs	1	Features	2

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getHeader()	0	4	1
A	getExtendedHeader()	0	4	1
A	setExtendedHeader()	0	10	2
A	getVersion()	0	4	1
A	getFrames()	0	4	1
A	addFrame()	0	5	1

<?php
/**
 * This file is part of the Metadata package.
 *
 * @author Daniel Schröder <daniel.schroeder@gravitymedia.de>
 */

namespace GravityMedia\Metadata\ID3v2;

use GravityMedia\Metadata\Exception\BadMethodCallException;
use GravityMedia\Metadata\ID3v2\Enum\Version;

/**
 * ID3v2 tag
 *
 * @package GravityMedia\Metadata\ID3v2
 */
class Tag implements TagInterface
{
    /**
     * @var HeaderInterface
     */
    protected $header;

    /**
     * @var ExtendedHeader
     */
    protected $extendedHeader;

    /**
     * @var FrameInterface[]
     */
    protected $frames;

    /**
     * Create tag object.
     *
     * @param HeaderInterface $header
     */
    public function __construct(HeaderInterface $header)
    {
        $this->header = $header;
        $this->frames = new \ArrayObject();

It seems like new \ArrayObject() of type object<ArrayObject> is incompatible with the declared type array<integer,object<GravityMedia\Metadata\ID3v2\FrameInterface>> of property $frames.

    }

    /**
     * Get header
     *
     * @return HeaderInterface
     */
    public function getHeader()
    {
        return $this->header;
    }

    /**
     * Get extended header
     *
     * @return ExtendedHeader
     */
    public function getExtendedHeader()
    {
        return $this->extendedHeader;
    }

    /**
     * Set extended header
     *
     * @param ExtendedHeaderInterface $extendedHeader
     *
     * @throws BadMethodCallException An exception is thrown on ID3 v2.2 tag
     *
     * @return $this
     */
    public function setExtendedHeader(ExtendedHeaderInterface $extendedHeader)
    {
        if (!in_array($this->getVersion(), [Version::VERSION_23, Version::VERSION_24])) {
            throw new BadMethodCallException('Extended header is not supported in this version.');
        }

        $this->extendedHeader = $extendedHeader;

$extendedHeader is of type object<GravityMedia\Metadata\ID3v2\ExtendedHeaderInterface>, but the property $extendedHeader was declared to be of type object<GravityMedia\Metadata\ID3v2\ExtendedHeader>. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getVersion()
    {
        return $this->header->getVersion();
    }

    /**
     * {@inheritdoc}
     */
    public function getFrames()
    {
        return $this->frames;
    }

    /**
     * Add frame
     *
     * @param FrameInterface $frame
     *
     * @return $this
     */
    public function addFrame(FrameInterface $frame)
    {
        $this->frames->append($frame);

The method append cannot be called on $this->frames (of type array<integer,object<GravityMedia\Metadata\ID3v2\FrameInterface>>).

        return $this;
    }
}