AbstractImage::setPalette() - Code Metrics - Inspection of "Added image color space, color profile and palette..." - GravityMedia/Magickly - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 1316ca...59eabb )

by Daniel

created 2016-04-12 13:29 UTC

AbstractImage::setPalette() A

↳ Parent: AbstractImage

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	15
rs	9.4285
cc	3
eloc	8
nc	3
nop	1

<?php
/**
 * This file is part of the Magickly project.
 *
 * @author Daniel Schröder <[email protected]>
 */

namespace GravityMedia\Magickly\Image;

use GravityMedia\Magickly\Enum\ColorSpace;
use GravityMedia\Magickly\Image\Palette\PaletteInterface;

/**
 * Abstract image class.
 *
 * @package GravityMedia\Magickly\Image
 */
abstract class AbstractImage implements ImageInterface
{
    /**
     * {@inheritdoc}
     */
    public function getPalette()
    {
        switch ($this->getColorSpace()) {
            default:
                $palette = new Palette\RGB();
                break;
            case ColorSpace::COLOR_SPACE_CMYK:
                $palette = new Palette\CMYK();
                break;
            case ColorSpace::COLOR_SPACE_GRAYSCALE:
                $palette = new Palette\Grayscale();
                break;
        }

        $colorProfile = $this->getColorProfile();
        if (null !== $colorProfile) {
            $palette->setColorProfile($colorProfile);
        }

        return $palette;
    }

    /**
     * {@inheritdoc}
     */
    public function setPalette(PaletteInterface $palette)
    {
        if ($this->getColorSpace() === $palette->getColorSpace()) {
            return $this;
        }

        if (null === $this->getColorProfile()) {
            $this->setColorProfile($this->getPalette()->getColorProfile());
        }

        $this->setColorProfile($palette->getColorProfile());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
        $this->setColorSpace($palette->getColorSpace());

        return $this;
    }
}


1			<?php
2			/**
3			* This file is part of the Magickly project.
4			*
5			* @author Daniel Schröder <[email protected]>
6			*/
7
8			namespace GravityMedia\Magickly\Image;
9
10			use GravityMedia\Magickly\Enum\ColorSpace;
11			use GravityMedia\Magickly\Image\Palette\PaletteInterface;
12
13			/**
14			* Abstract image class.
15			*
16			* @package GravityMedia\Magickly\Image
17			*/
18			abstract class AbstractImage implements ImageInterface
19			{
20			/**
21			* {@inheritdoc}
22			*/
23			public function getPalette()
24			{
25			switch ($this->getColorSpace()) {
26			default:
27			$palette = new Palette\RGB();
28			break;
29			case ColorSpace::COLOR_SPACE_CMYK:
30			$palette = new Palette\CMYK();
31			break;
32			case ColorSpace::COLOR_SPACE_GRAYSCALE:
33			$palette = new Palette\Grayscale();
34			break;
35			}
36
37			$colorProfile = $this->getColorProfile();
38			if (null !== $colorProfile) {
39			$palette->setColorProfile($colorProfile);
40			}
41
42			return $palette;
43			}
44
45			/**
46			* {@inheritdoc}
47			*/
48			public function setPalette(PaletteInterface $palette)
49			{
50			if ($this->getColorSpace() === $palette->getColorSpace()) {
51			return $this;
52			}
53
54			if (null === $this->getColorProfile()) {
55			$this->setColorProfile($this->getPalette()->getColorProfile());
56			}
57
58			$this->setColorProfile($palette->getColorProfile());
			0 ignored issues – show Bug introduced 2016-04-12 13:40 UTC by Report Bug Copy Issue Report It seems like `$palette->getColorProfile()` can be `null`; however, `setColorProfile()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
59			$this->setColorSpace($palette->getColorSpace());
60
61			return $this;
62			}
63			}
64

GravityMedia / Magickly

Push — master ( 1316ca...59eabb )

AbstractImage::setPalette() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like