Input - Code Metrics - GravityMedia/Ghostscript - Measure and Improve Code Quality continuously with Scrutinizer

Input A
last analyzed 2019-01-10 09:03 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	1
dl	0
loc	119
ccs	23
cts	23
cp	1
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	getProcessInput()	4	1
A	setProcessInput()	6	1
A	getPostScriptCode()	4	1
A	setPostScriptCode()	6	1
A	getFiles()	8	2
A	setFiles()	6	1
A	addFile()	10	2

<?php
/**
 * This file is part of the Ghostscript package.
 *
 * @author Daniel Schröder <[email protected]>
 */

namespace GravityMedia\Ghostscript;

use Symfony\Component\Process\ProcessUtils;

/**
 * The input class.
 *
 * @package GravityMedia\Ghostscript
 */
class Input
{
    /**
     * The process input.
     *
     * @var null|string|resource
     */
    private $processInput;

    /**
     * The PostScript code.
     *
     * @var null|string
     */
    private $postScriptCode;

    /**
     * The files.
     *
     * @var null|string[]
     */
    private $files;

    /**
     * Get process input.
     *
     * @return null|string|resource
     */
    public function getProcessInput()
    {
        return $this->processInput;
    }

    /**
     * Set process input.
     *
     * @param mixed $processInput
     *
     * @throws \InvalidArgumentException
     *
     * @return $this
     */
    public function setProcessInput($processInput)
    {
        $this->processInput = ProcessUtils::validateInput(__METHOD__, $processInput);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        return $this;
    }

    /**
     * Get PostScript code.
     *
     * @return null|string
     */
    public function getPostScriptCode()
    {
        return $this->postScriptCode;
    }

    /**
     * Set PostScript code.
     *
     * @param null|string $postScriptCode
     *
     * @return $this
     */
    public function setPostScriptCode($postScriptCode)
    {
        $this->postScriptCode = $postScriptCode;

        return $this;
    }

    /**
     * Get files.
     *
     * @return string[]
     */
    public function getFiles()
    {
        if (null === $this->files) {
            return [];
        }

        return $this->files;
    }

    /**
     * Add file.
     *
     * @param string $file
     *
     * @return $this
     */
    public function addFile($file)
    {
        if (null === $this->files) {
            $this->files = [];
        }

        $this->files[] = $file;

        return $this;
    }

    /**
     * Set files.
     *
     * @param string[] $files
     *
     * @return $this
     */
    public function setFiles(array $files)
    {
        $this->files = $files;

        return $this;
    }
}


1		<?php
2		/**
3		* This file is part of the Ghostscript package.
4		*
5		* @author Daniel Schröder <[email protected]>
6		*/
7
8		namespace GravityMedia\Ghostscript;
9
10		use Symfony\Component\Process\ProcessUtils;
11
12		/**
13		* The input class.
14		*
15		* @package GravityMedia\Ghostscript
16		*/
17		class Input
18		{
19		/**
20		* The process input.
21		*
22		* @var null\|string\|resource
23		*/
24		private $processInput;
25
26		/**
27		* The PostScript code.
28		*
29		* @var null\|string
30		*/
31		private $postScriptCode;
32
33		/**
34		* The files.
35		*
36		* @var null\|string[]
37		*/
38		private $files;
39
40		/**
41		* Get process input.
42		*
43		* @return null\|string\|resource
44		*/
45	4	public function getProcessInput()
46		{
47	4	return $this->processInput;
48		}
49
50		/**
51		* Set process input.
52		*
53		* @param mixed $processInput
54		*
55		* @throws \InvalidArgumentException
56		*
57		* @return $this
58		*/
59	2	public function setProcessInput($processInput)
60		{
61	2	$this->processInput = ProcessUtils::validateInput(__METHOD__, $processInput);
		0 ignored issues – show Documentation Bug introduced 2019-01-07 10:28 UTC by Report Bug Copy Issue Report It seems like `\Symfony\Component\Proce...ETHOD__, $processInput)` can also be of type `object<Iterator>`. However, the property `$processInput` is declared as type `null\|string\|resource`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
62
63	2	return $this;
64		}
65
66		/**
67		* Get PostScript code.
68		*
69		* @return null\|string
70		*/
71	4	public function getPostScriptCode()
72		{
73	4	return $this->postScriptCode;
74		}
75
76		/**
77		* Set PostScript code.
78		*
79		* @param null\|string $postScriptCode
80		*
81		* @return $this
82		*/
83	2	public function setPostScriptCode($postScriptCode)
84		{
85	2	$this->postScriptCode = $postScriptCode;
86
87	2	return $this;
88		}
89
90		/**
91		* Get files.
92		*
93		* @return string[]
94		*/
95	4	public function getFiles()
96		{
97	4	if (null === $this->files) {
98	2	return [];
99		}
100
101	2	return $this->files;
102		}
103
104		/**
105		* Add file.
106		*
107		* @param string $file
108		*
109		* @return $this
110		*/
111	2	public function addFile($file)
112		{
113	2	if (null === $this->files) {
114	2	$this->files = [];
115	1	}
116
117	2	$this->files[] = $file;
118
119	2	return $this;
120		}
121
122		/**
123		* Set files.
124		*
125		* @param string[] $files
126		*
127		* @return $this
128		*/
129	2	public function setFiles(array $files)
130		{
131	2	$this->files = $files;
132
133	2	return $this;
134		}
135		}
136

GravityMedia / Ghostscript

Input A last analyzed 2019-01-10 09:03 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like

Input A
last analyzed 2019-01-10 09:03 UTC