GloBee\PaymentApi\Models\PropertyTrait::__call()

Complexity

Conditions	3
Paths	3

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	PropertyTrait::__set()	0	3	1

<?php

namespace GloBee\PaymentApi\Models;

trait PropertyTrait
{
    /**
     * @param $name
     *
     * @return mixed
     */
    public function getProperty($name)
    {
        $methodName = 'get'.$this->strToStudlyCase($name);
        if (method_exists($this, $methodName)) {
            return $this->{$methodName}();
        }

        if (array_key_exists($name, $this->properties)) {
            return $this->properties[$name];
        }

        if (array_key_exists($name, $this->readonlyProperties)) {

It seems like $this->readonlyProperties can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

The property readonlyProperties does not exist on GloBee\PaymentApi\Models\PropertyTrait. Since you implemented __get, consider adding a @property annotation.

            return $this->readonlyProperties[$name];
        }
    }

    /**
     * @param $name
     * @param $value
     */
    protected function setProperty($name, $value)
    {
        $methodName = 'set'.$this->strToStudlyCase($name);
        if (method_exists($this, $methodName)) {
            $this->{$methodName}($value);

            return;
        }

        if (array_key_exists($name, $this->properties)) {
            $this->properties[$name] = $value;

The property properties does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            return;
        }
    }

    public function __get($name)
    {
        return $this->getProperty($name);
    }

    public function __set($name, $value)
    {
        $this->setProperty($name, $value);
    }

    /**
     * @param $key
     *
     * @return mixed
     */
    protected function strToStudlyCase($key)
    {
        return str_replace(' ', '', ucwords(str_replace('_', ' ', $key)));
    }
}