GloBee\PaymentApi\Models\PropertyTrait::getProperty()

Complexity

Conditions	4
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	4.0312

Importance

Changes

0

<?php
    public function getProperty($name)
    {
        $methodName = 'get'.$this->strToStudlyCase($name);
        if (method_exists($this, $methodName)) {
            return $this->{$methodName}();
        }

        if (array_key_exists($name, $this->properties)) {
            return $this->properties[$name];
        }

        if (array_key_exists($name, $this->readonlyProperties)) {

It seems like $this->readonlyProperties can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

The property readonlyProperties does not exist on GloBee\PaymentApi\Models\PropertyTrait. Since you implemented __get, consider adding a @property annotation.

            return $this->readonlyProperties[$name];
        }