TwigExtension::getConfig() - Code Metrics - Inspection of "New ACL, modify Auth, Renderer helpers!" - Gixx/WebHemi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 86c3d2...1ebd3c )

by Gabor

created 2017-02-21 13:09 UTC

TwigExtension::getConfig() A

↳ Parent: TwigExtension

Complexity

Conditions	3
Paths	4

Size

Total Lines	18
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	4
nop	1

<?php
/**
 * WebHemi.
 *
 * PHP version 7.1
 *
 * @copyright 2012 - 2017 Gixx-web (http://www.gixx-web.com)
 * @license   https://opensource.org/licenses/MIT The MIT License (MIT)
 *
 * @link      http://www.gixx-web.com
 */
declare(strict_types = 1);

namespace WebHemi\Adapter\Renderer\Twig;

use Twig_Extension;
use Twig_SimpleFilter;
use Twig_SimpleFunction;
use WebHemi\Adapter\DependencyInjection\DependencyInjectionAdapterInterface;
use WebHemi\Adapter\Renderer\RendererFilterInterface;
use WebHemi\Adapter\Renderer\RendererHelperInterface;
use WebHemi\Application\EnvironmentManager;
use WebHemi\Config\ConfigInterface;

/**
 * Class TwigExtension
 *
 * @codeCoverageIgnore - Test helpers and filters individually. It's only the shipped solution
 *                       to add them to the renderer.
 */
class TwigExtension extends Twig_Extension
{
    /** @var DependencyInjectionAdapterInterface */
    private $dependencyInjectionAdapter;
    /** @var ConfigInterface */
    private $configuration;
    /** @var EnvironmentManager */
    private $environmentManager;

    /**
     * WebHemiTwigExtension constructor.
     */
    public function __construct()
    {
        // Oh, this is a disgusting ugly hack...
        global $diAdapter;
function myFunction($a, $b) {
    // Do something
}
        $this->dependencyInjectionAdapter = $diAdapter;
        $this->configuration = $diAdapter->get(ConfigInterface::class);
        $this->environmentManager = $diAdapter->get(EnvironmentManager::class);
    }

    /**
     * Returns extension filters.
     *
     * @return array<Twig_SimpleFilter>
     */
    public function getFilters()
    {
        $filters = [];
        $filterConfig = $this->getConfig('filter');

        foreach ($filterConfig as $className) {
            /** @var RendererFilterInterface $callable */
            $callable = $this->dependencyInjectionAdapter->get($className);
            $filters[] = new Twig_SimpleFilter($callable::getName(), $callable);
        }

        return $filters;
    }

    /**
     * Returns extension functions.
     *
     * @return array<Twig_SimpleFunction>
     */
    public function getFunctions() : array
    {
        $functions = [];
        $helperConfig = $this->getConfig('helper');

        foreach ($helperConfig as $className) {
            /** @var RendererHelperInterface $callable */
            $callable = $this->dependencyInjectionAdapter->get($className);
            $functions[] = new Twig_SimpleFunction($callable::getName(), $callable);
        }

        return $functions;
    }

    /**
     * Returns the renderer config by type.
     *
     * @param string $type
     * @return array
     */
    private function getConfig(string $type) : array
    {
        $module = $this->environmentManager->getSelectedModule();
        $config = [];

        if ($this->configuration->has('renderer/Global/'.$type)) {
            $config = $this->configuration->getData('renderer/Global/' . $type);
        }

        if ($this->configuration->has('renderer/'.$module.'/'.$type)) {
            $config = merge_array_overwrite(
                $config,
                $this->configuration->getData('renderer/'.$module.'/'.$type)
            );
        }

        return $config;
    }
}


1			<?php
2			/**
3			* WebHemi.
4			*
5			* PHP version 7.1
6			*
7			* @copyright 2012 - 2017 Gixx-web (http://www.gixx-web.com)
8			* @license https://opensource.org/licenses/MIT The MIT License (MIT)
9			*
10			* @link http://www.gixx-web.com
11			*/
12			declare(strict_types = 1);
13
14			namespace WebHemi\Adapter\Renderer\Twig;
15
16			use Twig_Extension;
17			use Twig_SimpleFilter;
18			use Twig_SimpleFunction;
19			use WebHemi\Adapter\DependencyInjection\DependencyInjectionAdapterInterface;
20			use WebHemi\Adapter\Renderer\RendererFilterInterface;
21			use WebHemi\Adapter\Renderer\RendererHelperInterface;
22			use WebHemi\Application\EnvironmentManager;
23			use WebHemi\Config\ConfigInterface;
24
25			/**
26			* Class TwigExtension
27			*
28			* @codeCoverageIgnore - Test helpers and filters individually. It's only the shipped solution
29			* to add them to the renderer.
30			*/
31			class TwigExtension extends Twig_Extension
32			{
33			/** @var DependencyInjectionAdapterInterface */
34			private $dependencyInjectionAdapter;
35			/** @var ConfigInterface */
36			private $configuration;
37			/** @var EnvironmentManager */
38			private $environmentManager;
39
40			/**
41			* WebHemiTwigExtension constructor.
42			*/
43			public function __construct()
44			{
45			// Oh, this is a disgusting ugly hack...
46			global $diAdapter;
			1 ignored issue – show Compatibility Best Practice introduced 2017-02-21 13:16 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
47			$this->dependencyInjectionAdapter = $diAdapter;
48			$this->configuration = $diAdapter->get(ConfigInterface::class);
49			$this->environmentManager = $diAdapter->get(EnvironmentManager::class);
50			}
51
52			/**
53			* Returns extension filters.
54			*
55			* @return array<Twig_SimpleFilter>
56			*/
57			public function getFilters()
58			{
59			$filters = [];
60			$filterConfig = $this->getConfig('filter');
61
62			foreach ($filterConfig as $className) {
63			/** @var RendererFilterInterface $callable */
64			$callable = $this->dependencyInjectionAdapter->get($className);
65			$filters[] = new Twig_SimpleFilter($callable::getName(), $callable);
66			}
67
68			return $filters;
69			}
70
71			/**
72			* Returns extension functions.
73			*
74			* @return array<Twig_SimpleFunction>
75			*/
76			public function getFunctions() : array
77			{
78			$functions = [];
79			$helperConfig = $this->getConfig('helper');
80
81			foreach ($helperConfig as $className) {
82			/** @var RendererHelperInterface $callable */
83			$callable = $this->dependencyInjectionAdapter->get($className);
84			$functions[] = new Twig_SimpleFunction($callable::getName(), $callable);
85			}
86
87			return $functions;
88			}
89
90			/**
91			* Returns the renderer config by type.
92			*
93			* @param string $type
94			* @return array
95			*/
96			private function getConfig(string $type) : array
97			{
98			$module = $this->environmentManager->getSelectedModule();
99			$config = [];
100
101			if ($this->configuration->has('renderer/Global/'.$type)) {
102			$config = $this->configuration->getData('renderer/Global/' . $type);
103			}
104
105			if ($this->configuration->has('renderer/'.$module.'/'.$type)) {
106			$config = merge_array_overwrite(
107			$config,
108			$this->configuration->getData('renderer/'.$module.'/'.$type)
109			);
110			}
111
112			return $config;
113			}
114			}
115

Gixx / WebHemi

Push — master ( 86c3d2...1ebd3c )

TwigExtension::getConfig() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like