Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 23 | View Code Duplication | class UserToGroupCoupler extends AbstractDataCoupler |
|
|
|
|||
| 24 | { |
||
| 25 | /** @var string */ |
||
| 26 | protected $connectorIdKey = 'id_user_to_user_group'; |
||
| 27 | /** @var string */ |
||
| 28 | protected $connectorDataGroup = 'webhemi_user_to_user_group'; |
||
| 29 | /** @var array */ |
||
| 30 | protected $dependentDataGroups = [ |
||
| 31 | UserEntity::class => [ |
||
| 32 | 'source_key' => 'fk_user', |
||
| 33 | 'connector_key' => 'fk_user_group', |
||
| 34 | 'depending_group' => 'webhemi_user_group', |
||
| 35 | 'depending_id_key' => 'id_user_group', |
||
| 36 | ], |
||
| 37 | UserGroupEntity::class => [ |
||
| 38 | 'source_key' => 'fk_user_group', |
||
| 39 | 'connector_key' => 'fk_user', |
||
| 40 | 'depending_group' => 'webhemi_user', |
||
| 41 | 'depending_id_key' => 'id_user', |
||
| 42 | ] |
||
| 43 | ]; |
||
| 44 | |||
| 45 | use UserEntityTrait; |
||
| 46 | use UserGroupEntityTrait; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Gets a DataEntityInterface instance from the provided data according to the reference entity. |
||
| 50 | * |
||
| 51 | * @param DataEntityInterface $referenceEntity |
||
| 52 | * @param array $entityData |
||
| 53 | * @return DataEntityInterface |
||
| 54 | */ |
||
| 55 | protected function getDependingEntity(DataEntityInterface $referenceEntity, array $entityData) |
||
| 61 | } |
||
| 62 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.