This class seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
Loading history...
6
{
7
private $path;
8
9
3
public function __construct(string $path)
10
{
11
3
if (!is_file($path)) {
12
1
throw new NotFoundException(sprintf('The file `%s` does not exist.', $path));
13
}
14
15
2
$this->path = $path;
16
2
}
17
18
3
public static function create(string $path, string $content): File
19
{
20
3
if (is_file($path)) {
21
1
throw new ExistsException(sprintf('The file `%s` already exists.', $path));
It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.
If you suppress an error, we recommend checking for the error condition explicitly:
// For example instead of@mkdir($dir);// Better useif(@mkdir($dir)===false){thrownew\RuntimeException('The directory '.$dir.' could not be created.');}
Loading history...
25
26
2
if (!is_file($path)) {
27
1
throw new PermissionDeniedException(error_get_last()['message'], error_get_last()['type']);
Gitilicious /
git-client
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.