Issues in Series.php (master) - Issues in master - GinoPane/oc-blogtaxonomy-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (55)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

controllers/Series.php (3 issues)

Labels

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GinoPane\BlogTaxonomy\Controllers;

use Flash;
use BackendMenu;
use Backend\Classes\Controller;
use GinoPane\BlogTaxonomy\Plugin;
use Backend\Behaviors\FormController;
use Backend\Behaviors\ListController;
use Backend\Behaviors\RelationController;
use GinoPane\BlogTaxonomy\Models\Series as SeriesModel;

/**
 * Class Series
 *
 * @package GinoPane\BlogTaxonomy\Controllers
 */
class Series extends Controller

{
    /**
     * Behaviours implemented by the controller
     *
     * @var array
     */
    public $implement = [
        FormController::class,
        ListController::class,
        RelationController::class
    ];

    public $formConfig = 'config_form.yaml';
    public $listConfig = 'config_list.yaml';
    public $relationConfig = 'config_relation.yaml';

    /**
     * Series constructor
     */
    public function __construct()
    {
        parent::__construct();

        BackendMenu::setContext(Plugin::REQUIRED_PLUGIN_RAINLAB_BLOG, 'blog', 'series');
    }

    /**
     * Controller "update" action used for updating existing model records.
     * This action takes a record identifier (primary key of the model)
     * to locate the record used for sourcing the existing form values.
     *
     * @param int $recordId Record identifier

     * @param string $context Form context

     * @return void
     */
    public function update($recordId = null, $context = null)
    {
        $series = SeriesModel::whereId($recordId)->first();

        if ($series !== null) {
            $this->pageTitle = trans(Plugin::LOCALIZATION_KEY . 'form.series.edit_title', ['series' => $series->title]);
        } else {
            $this->pageTitle = trans(Plugin::LOCALIZATION_KEY . 'form.series.series_does_not_exist');
        }

        return $this->asExtension('FormController')->update($recordId, $context);
    }

    /**
     * Remove multiple tags
     *
     * @return mixed
     */
    public function onBulkDelete()
    {
        if ($checkedIds = (array)post('checked', [])) {
            $delete = SeriesModel::whereIn('id', $checkedIds)->delete();
        }

        if (empty($delete)) {
            Flash::error(e(trans(Plugin::LOCALIZATION_KEY . 'form.errors.unknown')));

            return;
        }

        Flash::success(e(trans(Plugin::LOCALIZATION_KEY . 'form.series.delete_series_success')));

        return $this->listRefresh();
    }
}


1		<?php
2
3		namespace GinoPane\BlogTaxonomy\Controllers;
4
5		use Flash;
6		use BackendMenu;
7		use Backend\Classes\Controller;
8		use GinoPane\BlogTaxonomy\Plugin;
9		use Backend\Behaviors\FormController;
10		use Backend\Behaviors\ListController;
11		use Backend\Behaviors\RelationController;
12		use GinoPane\BlogTaxonomy\Models\Series as SeriesModel;
13
14		/**
15		* Class Series
16		*
17		* @package GinoPane\BlogTaxonomy\Controllers
18		*/
19	View Code Duplication	class Series extends Controller
		0 ignored issues – show Duplication introduced 2021-03-25 18:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
20		{
21		/**
22		* Behaviours implemented by the controller
23		*
24		* @var array
25		*/
26		public $implement = [
27		FormController::class,
28		ListController::class,
29		RelationController::class
30		];
31
32		public $formConfig = 'config_form.yaml';
33		public $listConfig = 'config_list.yaml';
34		public $relationConfig = 'config_relation.yaml';
35
36		/**
37		* Series constructor
38		*/
39		public function __construct()
40		{
41		parent::__construct();
42
43		BackendMenu::setContext(Plugin::REQUIRED_PLUGIN_RAINLAB_BLOG, 'blog', 'series');
44		}
45
46		/**
47		* Controller "update" action used for updating existing model records.
48		* This action takes a record identifier (primary key of the model)
49		* to locate the record used for sourcing the existing form values.
50		*
51		* @param int $recordId Record identifier
		0 ignored issues – show Documentation introduced 2020-01-12 15:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$recordId` not be `integer\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
52		* @param string $context Form context
		0 ignored issues – show Documentation introduced 2020-01-12 15:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the type for parameter `$context` not be `string\|null`? This check looks for `@param` annotations where the type inferred by our type inference engine differs from the declared type. It makes a suggestion as to what type it considers more descriptive. Most often this is a case of a parameter that can be null in addition to its declared types. Loading history...
53		* @return void
54		*/
55		public function update($recordId = null, $context = null)
56		{
57		$series = SeriesModel::whereId($recordId)->first();
58
59		if ($series !== null) {
60		$this->pageTitle = trans(Plugin::LOCALIZATION_KEY . 'form.series.edit_title', ['series' => $series->title]);
61		} else {
62		$this->pageTitle = trans(Plugin::LOCALIZATION_KEY . 'form.series.series_does_not_exist');
63		}
64
65		return $this->asExtension('FormController')->update($recordId, $context);
66		}
67
68		/**
69		* Remove multiple tags
70		*
71		* @return mixed
72		*/
73		public function onBulkDelete()
74		{
75		if ($checkedIds = (array)post('checked', [])) {
76		$delete = SeriesModel::whereIn('id', $checkedIds)->delete();
77		}
78
79		if (empty($delete)) {
80		Flash::error(e(trans(Plugin::LOCALIZATION_KEY . 'form.errors.unknown')));
81
82		return;
83		}
84
85		Flash::success(e(trans(Plugin::LOCALIZATION_KEY . 'form.series.delete_series_success')));
86
87		return $this->listRefresh();
88		}
89		}
90

GinoPane / oc-blogtaxonomy-plugin

Issues (55)

Security Analysis no request data

controllers/Series.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like