Issues in SeriesNavigation.php (master) - Issues in master - GinoPane/oc-blogtaxonomy-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (55)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

components/SeriesNavigation.php (2 issues)

Labels

Documentation 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GinoPane\BlogTaxonomy\Components;

use Cms\Classes\Page;
use GinoPane\BlogTaxonomy\Plugin;
use GinoPane\BlogTaxonomy\Models\Series;
use GinoPane\BlogTaxonomy\Models\ModelAbstract;
use GinoPane\BlogTaxonomy\Classes\ComponentAbstract;

/**
 * Class SeriesNavigation
 *
 * @package GinoPane\BlogTaxonomy\Components
 */
class SeriesNavigation extends ComponentAbstract
{
    const NAME = 'seriesNavigation';

    /**
     * @var Series
     */
    public $series;

    /**
     * Post slug
     *
     * @var string
     */
    public $slug;

    /**
     * @var int
     */
    public $smallNav;

    /**
     * Reference to the page name for linking to posts
     *
     * @var string
     */
    public $postPage;

    /**
     * Reference to the page name for linking to series
     *
     * @var string
     */
    public $seriesPage;

    /**
     * @return array

     */
    public function componentDetails()
    {
        return [
            'name'        => Plugin::LOCALIZATION_KEY . 'components.series_navigation.name',
            'description' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.description'
        ];
    }

    /**
     * @return array

     */
    public function defineProperties()
    {
        return [
            'slug' => [
                'title'       =>  Plugin::LOCALIZATION_KEY . 'components.series_navigation.post_slug_title',
                'description' =>  Plugin::LOCALIZATION_KEY . 'components.series_navigation.post_slug_description',
                'default'     => '{{ :slug }}',
                'type'        => 'string'
            ],
            'seriesPage' => [
                'title'       => Plugin::LOCALIZATION_KEY . 'components.series_navigation.series_page_title',
                'description' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.series_page_description',
                'type'        => 'dropdown',
                'default'     => 'blog/series',
                'group'       => Plugin::LOCALIZATION_KEY . 'components.series_navigation.links_group',
            ],
            'postPage' => [
                'title'       => 'rainlab.blog::lang.settings.posts_post',
                'description' => 'rainlab.blog::lang.settings.posts_post_description',
                'type'        => 'dropdown',
                'default'     => 'blog/post',
                'group'       => Plugin::LOCALIZATION_KEY . 'components.series_navigation.links_group',
            ]
        ];
    }

    /**
     * @return mixed
     */
    public function getPostPageOptions()
    {
        return Page::sortBy('baseFileName')->lists('baseFileName', 'baseFileName');
    }

    /**
     * @return mixed
     */
    public function getSeriesPageOptions()
    {
        return Page::sortBy('baseFileName')->lists('baseFileName', 'baseFileName');
    }

    /**
     * @return void
     */
    public function onRun()
    {
        $this->postPage   = $this->property('postPage');
        $this->seriesPage = $this->property('seriesPage');
        $this->slug       = $this->page['slug'] = $this->property('slug');
        $this->series     = $this->page['series'] = $this->listSeries();
    }

    /**
     * Get Series
     *
     * @return mixed
     */
    protected function listSeries()
    {
        $series = Series::whereHas(
            'posts',
            function($query) {
                ModelAbstract::whereTranslatableProperty($query, 'slug', $this->property('slug'));
            }
        )->with(
            [
                'posts' => static function($query) {
                    $query->isPublished();
                }
            ]
        )->first();

        if ($series !== null) {
            $seriesComponent = $this->getComponent(SeriesPosts::NAME, $this->seriesPage);

            $series->setUrl($this->seriesPage, $this->controller, [
                'series' => $this->urlProperty($seriesComponent, 'series')
            ]);

            $this->setPostUrls($series->posts);
        }

        return $series;
    }
}


1			<?php
2
3			namespace GinoPane\BlogTaxonomy\Components;
4
5			use Cms\Classes\Page;
6			use GinoPane\BlogTaxonomy\Plugin;
7			use GinoPane\BlogTaxonomy\Models\Series;
8			use GinoPane\BlogTaxonomy\Models\ModelAbstract;
9			use GinoPane\BlogTaxonomy\Classes\ComponentAbstract;
10
11			/**
12			* Class SeriesNavigation
13			*
14			* @package GinoPane\BlogTaxonomy\Components
15			*/
16			class SeriesNavigation extends ComponentAbstract
17			{
18			const NAME = 'seriesNavigation';
19
20			/**
21			* @var Series
22			*/
23			public $series;
24
25			/**
26			* Post slug
27			*
28			* @var string
29			*/
30			public $slug;
31
32			/**
33			* @var int
34			*/
35			public $smallNav;
36
37			/**
38			* Reference to the page name for linking to posts
39			*
40			* @var string
41			*/
42			public $postPage;
43
44			/**
45			* Reference to the page name for linking to series
46			*
47			* @var string
48			*/
49			public $seriesPage;
50
51			/**
52			* @return array
			0 ignored issues – show Documentation introduced 2018-05-31 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `array<string,string>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
53			*/
54			public function componentDetails()
55			{
56			return [
57			'name' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.name',
58			'description' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.description'
59			];
60			}
61
62			/**
63			* @return array
			0 ignored issues – show Documentation introduced 2018-08-09 19:29 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider making the return type a bit more specific; maybe use `array<string,array<string,string>>`. This check looks for the generic type `array` as a return type and suggests a more specific type. This type is inferred from the actual code. Loading history...
64			*/
65			public function defineProperties()
66			{
67			return [
68			'slug' => [
69			'title' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.post_slug_title',
70			'description' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.post_slug_description',
71			'default' => '{{ :slug }}',
72			'type' => 'string'
73			],
74			'seriesPage' => [
75			'title' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.series_page_title',
76			'description' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.series_page_description',
77			'type' => 'dropdown',
78			'default' => 'blog/series',
79			'group' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.links_group',
80			],
81			'postPage' => [
82			'title' => 'rainlab.blog::lang.settings.posts_post',
83			'description' => 'rainlab.blog::lang.settings.posts_post_description',
84			'type' => 'dropdown',
85			'default' => 'blog/post',
86			'group' => Plugin::LOCALIZATION_KEY . 'components.series_navigation.links_group',
87			]
88			];
89			}
90
91			/**
92			* @return mixed
93			*/
94			public function getPostPageOptions()
95			{
96			return Page::sortBy('baseFileName')->lists('baseFileName', 'baseFileName');
97			}
98
99			/**
100			* @return mixed
101			*/
102			public function getSeriesPageOptions()
103			{
104			return Page::sortBy('baseFileName')->lists('baseFileName', 'baseFileName');
105			}
106
107			/**
108			* @return void
109			*/
110			public function onRun()
111			{
112			$this->postPage = $this->property('postPage');
113			$this->seriesPage = $this->property('seriesPage');
114			$this->slug = $this->page['slug'] = $this->property('slug');
115			$this->series = $this->page['series'] = $this->listSeries();
116			}
117
118			/**
119			* Get Series
120			*
121			* @return mixed
122			*/
123			protected function listSeries()
124			{
125			$series = Series::whereHas(
126			'posts',
127			function($query) {
128			ModelAbstract::whereTranslatableProperty($query, 'slug', $this->property('slug'));
129			}
130			)->with(
131			[
132			'posts' => static function($query) {
133			$query->isPublished();
134			}
135			]
136			)->first();
137
138			if ($series !== null) {
139			$seriesComponent = $this->getComponent(SeriesPosts::NAME, $this->seriesPage);
140
141			$series->setUrl($this->seriesPage, $this->controller, [
142			'series' => $this->urlProperty($seriesComponent, 'series')
143			]);
144
145			$this->setPostUrls($series->posts);
146			}
147
148			return $series;
149			}
150			}
151

GinoPane / oc-blogtaxonomy-plugin

Issues (55)

Security Analysis no request data

components/SeriesNavigation.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like