Issues in ComponentAbstract.php (master) - Issues in master - GinoPane/oc-blogtaxonomy-plugin - Measure and Improve Code Quality continuously with Scrutinizer

Issues (55)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

classes/ComponentAbstract.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace GinoPane\BlogTaxonomy\Classes;

use ArrayAccess;
use Cms\Classes\Page;
use Cms\Classes\Theme;
use Cms\Classes\Controller;
use RainLab\Blog\Models\Post;
use Cms\Classes\ComponentBase;
use RainLab\Blog\Models\Category;
use October\Rain\Database\Collection;

/**
 * Class ComponentAbstract
 *
 * @package GinoPane\BlogTaxonomy\Classes
 */
abstract class ComponentAbstract extends ComponentBase
{
    /**
     * Reference to the page name for linking to posts
     *
     * @var string
     */
    protected $postPage;

    /**
     * Reference to the page name for linking to categories
     *
     * @var string
     */
    protected $categoryPage;

    /**
     * @param Collection $items
     * @param string $urlPage
     * @param Controller $controller
     * @param array $modelUrlParams
     */
    protected function setUrls(
        Collection $items,
        string $urlPage,
        Controller $controller,
        array $modelUrlParams = array()
    ) {
        if ($items) {
            foreach ($items as $item) {
                $item->setUrl($urlPage, $controller, $modelUrlParams);
            }
        }
    }

    /**
     * Set Urls to posts
     *
     * @param ArrayAccess $posts
     */
    protected function setPostUrls(ArrayAccess $posts)
    {
        // Add a "url" helper attribute for linking to each post and category
        if (!empty($this->postPage) && $posts && $posts->count()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $posts->each(function ($post) {
                $this->setPostUrl($post);

                if (!empty($this->categoryPage) && $post->categories->count()) {
                    $post->categories->each(function ($category) {
                        /** @var Category $category */
                        $category->setUrl(
                            $this->categoryPage,
                            $this->controller
                        );
                    });
                }
            });
        }
    }

    protected function setPostUrl(Post $post)
    {
        $post->setUrl(
            $this->postPage,
            $this->controller
        );
    }

    /**
     * A helper function to get the real URL parameter name. For example, slug for posts
     * can be injected as :post into URL. Real argument is necessary if you want to generate
     * valid URLs for such pages
     *
     * @param ComponentBase|null $component
     * @param string $name
     *
     * @return string|null
     */
    protected function urlProperty(ComponentBase $component = null, string $name = '')
    {
        $property = null;

        if ($component !== null && ($property = $component->property($name))) {
            preg_match('/{{ :([^ ]+) }}/', $property, $matches);

            if (isset($matches[1])) {
                $property = $matches[1];
            }
        } else {
            $property = $name;
        }

        return $property;
    }

    /**
     * Returns page property defaulting to the value from defineProperties() array with fallback
     * to explicitly passed default value
     *
     * @param string $property
     * @param $default
     *
     * @return mixed
     */
    public function getProperty(string $property, $default = null)
    {
        return $this->property($property, $this->defineProperties()[$property]['default'] ?? $default);
    }

    /**
     * @param string $componentName
     * @param string $page
     * @return ComponentBase|null
     */
    protected function getComponent(string $componentName, string $page)
    {
        $component = null;

        $page = Page::load(Theme::getActiveTheme(), $page);

        if ($page !== null) {
            $component = $page->getComponent($componentName);
        }

        return $component;
    }
}


1			<?php
2
3			namespace GinoPane\BlogTaxonomy\Classes;
4
5			use ArrayAccess;
6			use Cms\Classes\Page;
7			use Cms\Classes\Theme;
8			use Cms\Classes\Controller;
9			use RainLab\Blog\Models\Post;
10			use Cms\Classes\ComponentBase;
11			use RainLab\Blog\Models\Category;
12			use October\Rain\Database\Collection;
13
14			/**
15			* Class ComponentAbstract
16			*
17			* @package GinoPane\BlogTaxonomy\Classes
18			*/
19			abstract class ComponentAbstract extends ComponentBase
20			{
21			/**
22			* Reference to the page name for linking to posts
23			*
24			* @var string
25			*/
26			protected $postPage;
27
28			/**
29			* Reference to the page name for linking to categories
30			*
31			* @var string
32			*/
33			protected $categoryPage;
34
35			/**
36			* @param Collection $items
37			* @param string $urlPage
38			* @param Controller $controller
39			* @param array $modelUrlParams
40			*/
41			protected function setUrls(
42			Collection $items,
43			string $urlPage,
44			Controller $controller,
45			array $modelUrlParams = array()
46			) {
47			if ($items) {
48			foreach ($items as $item) {
49			$item->setUrl($urlPage, $controller, $modelUrlParams);
50			}
51			}
52			}
53
54			/**
55			* Set Urls to posts
56			*
57			* @param ArrayAccess $posts
58			*/
59			protected function setPostUrls(ArrayAccess $posts)
60			{
61			// Add a "url" helper attribute for linking to each post and category
62			if (!empty($this->postPage) && $posts && $posts->count()) {
			0 ignored issues – show Bug introduced 2019-05-11 12:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `ArrayAccess` as the method `count()` does only exist in the following implementations of said interface: `ArrayIterator`, `ArrayObject`, `CachingIterator`, `PDepend\Source\AST\ASTArtifactList`, `PDepend\Source\AST\ASTCl...erfaceReferenceIterator`, `Phar`, `PharData`, `RecursiveArrayIterator`, `RecursiveCachingIterator`, `SplDoublyLinkedList`, `SplFixedArray`, `SplObjectStorage`, `SplQueue`, `SplStack`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
63			$posts->each(function ($post) {
64			$this->setPostUrl($post);
65
66			if (!empty($this->categoryPage) && $post->categories->count()) {
67			$post->categories->each(function ($category) {
68			/** @var Category $category */
69			$category->setUrl(
70			$this->categoryPage,
71			$this->controller
72			);
73			});
74			}
75			});
76			}
77			}
78
79			protected function setPostUrl(Post $post)
80			{
81			$post->setUrl(
82			$this->postPage,
83			$this->controller
84			);
85			}
86
87			/**
88			* A helper function to get the real URL parameter name. For example, slug for posts
89			* can be injected as :post into URL. Real argument is necessary if you want to generate
90			* valid URLs for such pages
91			*
92			* @param ComponentBase\|null $component
93			* @param string $name
94			*
95			* @return string\|null
96			*/
97			protected function urlProperty(ComponentBase $component = null, string $name = '')
98			{
99			$property = null;
100
101			if ($component !== null && ($property = $component->property($name))) {
102			preg_match('/{{ :([^ ]+) }}/', $property, $matches);
103
104			if (isset($matches[1])) {
105			$property = $matches[1];
106			}
107			} else {
108			$property = $name;
109			}
110
111			return $property;
112			}
113
114			/**
115			* Returns page property defaulting to the value from defineProperties() array with fallback
116			* to explicitly passed default value
117			*
118			* @param string $property
119			* @param $default
120			*
121			* @return mixed
122			*/
123			public function getProperty(string $property, $default = null)
124			{
125			return $this->property($property, $this->defineProperties()[$property]['default'] ?? $default);
126			}
127
128			/**
129			* @param string $componentName
130			* @param string $page
131			* @return ComponentBase\|null
132			*/
133			protected function getComponent(string $componentName, string $page)
134			{
135			$component = null;
136
137			$page = Page::load(Theme::getActiveTheme(), $page);
138
139			if ($page !== null) {
140			$component = $page->getComponent($componentName);
141			}
142
143			return $component;
144			}
145			}
146

GinoPane / oc-blogtaxonomy-plugin

Issues (55)

Security Analysis no request data

classes/ComponentAbstract.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like