GinoPane\BlogTaxonomy\Classes\MigrationCommand\MigrationFactory

Complexity

Total Complexity

2

Size/Duplication

Total Lines	22
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	resolve()	0	12	2

<?php

namespace GinoPane\BlogTaxonomy\Classes\MigrationCommand;

use GinoPane\BlogTaxonomy\Classes\MigrationCommand\Exceptions\NoPluginException;
use GinoPane\BlogTaxonomy\Classes\MigrationCommand\Migrations\NullMigration;
use GinoPane\BlogTaxonomy\Classes\MigrationCommand\Migrations\PkleindienstBlogSeriesMigration;
use Illuminate\Console\Command;

/**
 * Class MigrationFactory
 *
 * @package GinoPane\BlogTaxonomy\Classes\MigrationCommand
 */
class MigrationFactory

MigrationFactory does not seem to conform to the naming convention (Utils?$).

{
    /**
     * @param string $plugin
     *
     * @throws NoPluginException
     *
     * @return MigrationInterface
     */
    public static function resolve(string $plugin, Command $command): MigrationInterface
    {
        $plugin = strtolower($plugin);

Consider using a different name than the parameter $plugin. This often makes code more readable.

        $migration = new NullMigration($command);

        switch ($plugin) {
            case strtolower(PkleindienstBlogSeriesMigration::PLUGIN_NAME):
                $migration = new PkleindienstBlogSeriesMigration($command);
        }

        return $migration;
    }
}