Producer::circleByNumber() - Code Metrics - Inspection of "Release #1" - GetSky/php-airac - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f3855...308ed5 )

by Alexander

created 2018-07-20 22:32 UTC

Producer::circleByNumber() A

↳ Parent: Producer

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	8
ccs	4
cts	4
cp	1
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php
namespace GetSky\AIRAC;

/**
 * Class Producer
 * @deprecated Use AiracProducer. This class will be removed in version 1.2.0
 * @package GetSky\AIRAC
 */
class Producer
{
    /**
     * @var \DateTime
     */
    private $bearing;

    /**
     * @param \DateTime|null $bearing
     */
    public function __construct(\DateTime $bearing = null)
    {
         $this->bearing = $bearing ? $bearing : new \DateTime('2016-01-07');
    }

    /**
     * @return \DateTime
     */
    public function getBearingDate(): \DateTime
    {
        return $this->bearing;
    }

    /**
     * Get next AIRAC date.
     *
     * @param \DateTime $date
     * @return Airac
     */
    public function next(\DateTime $date): Airac
    {
        return $this->circle($date, 1);
    }

    /**
     * Get next AIRAC date.
     *
     * @param string $number
     * @return Airac
     * @throws AiracNumberValidationException
     */
    public function nextByNumber(string $number): Airac
    {
        return $this->circleByNumber($number, 1);
    }

    /**
     * Get current AIRAC date.
     *
     * @param \DateTime $date
     * @return Airac
     */
    public function now(\DateTime $date): Airac
    {
        return $this->circle($date, 0);
    }

    /**
     * Get current AIRAC date.
     *
     * @param string $number
     * @return Airac
     * @throws AiracNumberValidationException
     */
    public function nowByNumber(string $number): Airac
    {
        return $this->circleByNumber($number, 0);
    }

    /**
     * Get last AIRAC date.
     *
     * @param \DateTime $date
     * @return Airac
     */
    public function last(\DateTime $date): Airac
    {
        return $this->circle($date, -1);
    }

    /**
     * Get last AIRAC date.
     *
     * @param string $number
     * @return Airac
     * @throws AiracNumberValidationException
     */
    public function lastByNumber(string $number): Airac
    {
        return $this->circleByNumber($number, -1);
    }

    /**
     * Generator AIRAC dates.
     *
     * @param \DateTime $date
     * @param $step
     * @return Airac
     */
    private function circle(\DateTime $date, int $step): Airac
    {
        $positive = ($date >= $this->bearing) ? 1 : -1;
        $days = $date->diff($this->bearing)->days;
        $countCircle = $positive * floor($days / 28) + $step - (($positive < 0 && $days % 28 != 0) ? 1 : 0);
        $dateStart = clone $this->bearing;
        $dateStart->modify(($countCircle * 28) . ' day');
        $dateEnd = clone $dateStart;
        $dateEnd->modify('28 day');
        
        return new Airac($dateStart, $dateEnd, $this->calcNumber($dateStart));
    }

    /**
     * Generator AIRAC dates.
     *
     * @param string $number
     * @param int $step
     * @return Airac
     * @throws AiracNumberValidationException
     */
    private function circleByNumber(string $number, int $step): Airac
    {
        if (preg_match("/[0-9]{4}/", $number) == false) {

            throw new AiracNumberValidationException("Number '$number' isn't correct AIRAC.");
        }

        return $this->circle(\DateTime::createFromFormat('!y', substr($number, 0, 2)), $step + substr($number, 2, 2));

    }

    /**
     *Calculated number of AIRAC.
     *
     * @param \DateTime $date
     * @return string
     */
    private function calcNumber(\DateTime $date): string
    {
        $year = \DateTime::createFromFormat('!Y', $date->format('Y'));
        $number = 1 + floor($year->diff($date)->days / 28);
        
        return $year->format('y') . sprintf("%02d", $number);
    }
}


1		<?php
2		namespace GetSky\AIRAC;
3
4		/**
5		* Class Producer
6		* @deprecated Use AiracProducer. This class will be removed in version 1.2.0
7		* @package GetSky\AIRAC
8		*/
9		class Producer
10		{
11		/**
12		* @var \DateTime
13		*/
14		private $bearing;
15
16		/**
17		* @param \DateTime\|null $bearing
18		*/
19	45	public function __construct(\DateTime $bearing = null)
20		{
21	45	$this->bearing = $bearing ? $bearing : new \DateTime('2016-01-07');
22	45	}
23
24		/**
25		* @return \DateTime
26		*/
27	2	public function getBearingDate(): \DateTime
28		{
29	2	return $this->bearing;
30		}
31
32		/**
33		* Get next AIRAC date.
34		*
35		* @param \DateTime $date
36		* @return Airac
37		*/
38	6	public function next(\DateTime $date): Airac
39		{
40	6	return $this->circle($date, 1);
41		}
42
43		/**
44		* Get next AIRAC date.
45		*
46		* @param string $number
47		* @return Airac
48		* @throws AiracNumberValidationException
49		*/
50	13	public function nextByNumber(string $number): Airac
51		{
52	13	return $this->circleByNumber($number, 1);
53		}
54
55		/**
56		* Get current AIRAC date.
57		*
58		* @param \DateTime $date
59		* @return Airac
60		*/
61	6	public function now(\DateTime $date): Airac
62		{
63	6	return $this->circle($date, 0);
64		}
65
66		/**
67		* Get current AIRAC date.
68		*
69		* @param string $number
70		* @return Airac
71		* @throws AiracNumberValidationException
72		*/
73	6	public function nowByNumber(string $number): Airac
74		{
75	6	return $this->circleByNumber($number, 0);
76		}
77
78		/**
79		* Get last AIRAC date.
80		*
81		* @param \DateTime $date
82		* @return Airac
83		*/
84	6	public function last(\DateTime $date): Airac
85		{
86	6	return $this->circle($date, -1);
87		}
88
89		/**
90		* Get last AIRAC date.
91		*
92		* @param string $number
93		* @return Airac
94		* @throws AiracNumberValidationException
95		*/
96	6	public function lastByNumber(string $number): Airac
97		{
98	6	return $this->circleByNumber($number, -1);
99		}
100
101		/**
102		* Generator AIRAC dates.
103		*
104		* @param \DateTime $date
105		* @param $step
106		* @return Airac
107		*/
108	36	private function circle(\DateTime $date, int $step): Airac
109		{
110	36	$positive = ($date >= $this->bearing) ? 1 : -1;
111	36	$days = $date->diff($this->bearing)->days;
112	36	$countCircle = $positive * floor($days / 28) + $step - (($positive < 0 && $days % 28 != 0) ? 1 : 0);
113	36	$dateStart = clone $this->bearing;
114	36	$dateStart->modify(($countCircle * 28) . ' day');
115	36	$dateEnd = clone $dateStart;
116	36	$dateEnd->modify('28 day');
117
118	36	return new Airac($dateStart, $dateEnd, $this->calcNumber($dateStart));
119		}
120
121		/**
122		* Generator AIRAC dates.
123		*
124		* @param string $number
125		* @param int $step
126		* @return Airac
127		* @throws AiracNumberValidationException
128		*/
129	25	private function circleByNumber(string $number, int $step): Airac
130		{
131	25	if (preg_match("/[0-9]{4}/", $number) == false) {
		0 ignored issues – show Bug Best Practice introduced 2018-07-20 22:34 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `preg_match('/[0-9]{4}/', $number)` of type `integer` to the boolean `false`. If you are specifically checking for 0, consider using something more explicit like `=== 0` instead. Loading history...
132	7	throw new AiracNumberValidationException("Number '$number' isn't correct AIRAC.");
133		}
134
135	18	return $this->circle(\DateTime::createFromFormat('!y', substr($number, 0, 2)), $step + substr($number, 2, 2));
		0 ignored issues – show Security Bug introduced 2018-07-20 22:34 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor... substr($number, 0, 2))` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `GetSky\AIRAC\Producer::circle()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
136		}
137
138		/**
139		*Calculated number of AIRAC.
140		*
141		* @param \DateTime $date
142		* @return string
143		*/
144	36	private function calcNumber(\DateTime $date): string
145		{
146	36	$year = \DateTime::createFromFormat('!Y', $date->format('Y'));
147	36	$number = 1 + floor($year->diff($date)->days / 28);
148
149	36	return $year->format('y') . sprintf("%02d", $number);
150		}
151		}
152

GetSky / php-airac

Push — master ( 8f3855...308ed5 )

Producer::circleByNumber() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like