Germania\IpstackClient\IpstackClientPsr6CacheDecorator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Test Coverage

Coverage

93.75%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	2
A	get()	0	29	2

<?php
namespace Germania\IpstackClient;

use Germania\IpstackClient\IpstackClientInterface;
use Psr\Cache\CacheItemPoolInterface;
use Psr\Log\LoggerInterface;
use Psr\Log\NullLogger;
use Psr\Log\LoggerAwareTrait;

class IpstackClientPsr6CacheDecorator implements IpstackClientInterface
{
	use LoggerAwareTrait;


	/**
	 * @var CacheItemPoolInterface
	 */
	public $cache;


	/**
	 * @param IpstackClientInterface $ipstack_client
	 * @param CacheItemPoolInterface $cache           PSR-6 Cache ItemPool
	 */
	public function __construct( IpstackClientInterface $ipstack_client, CacheItemPoolInterface $cache, LoggerInterface $logger = null )
	{
		$this->ipstack_client = $ipstack_client;

The property ipstack_client does not exist. Did you maybe forget to declare it?

		$this->cache = $cache;
		$this->setLogger( $logger ?: new NullLogger );
	}



	public function get( string $client_ip, array $custom_query = array() ) : array
    {

        $item = $this->cache->getItem( $client_ip );

        $ipstack = $item->get();

        // No valid item?
        if($item->isMiss()):
            $this->logger->debug("No ipstack info in cache");

            // Let other processes know that this one is rebuilding the data.
            $item->lock();

            // Run intensive code: Ask ipstack directly
            $ipstack = $this->ipstack_client->get( $client_ip, $custom_query );

            // Store data for future use.
            $this->logger->info("Write ipstack info to cache", $ipstack);
            $this->cache->save($item->set($ipstack));

        // Valid cache item found
        else:
            $this->logger->notice("Found ipstack info in cache", $ipstack);
        endif;

        return $ipstack;

	}	

}