Germania\VatIdNo\Filters\WithVatIdNoFilterIterator

Complexity

Total Complexity

9

Size/Duplication

Total Lines	31
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	3
A	accept()	15	15	6

<?php
namespace Germania\VatIdNo\Filters;

use Germania\VatIdNo\VatIdNoProviderInterface;

class WithVatIdNoFilterIterator extends \FilterIterator

This class seems to be duplicated in your project.

{
    public $field = "vatin";

    public function __construct(\Traversable $iterator, $field = null)
    {
        if ($iterator instanceof \Iterator) {
            parent::__construct($iterator);
        } else {
            parent::__construct($iterator->getIterator());

It seems like you code against a concrete implementation and not the interface Traversable as the method getIterator() does only exist in the following implementations of said interface: ArrayAccessible, ArrayObject, Doctrine\Common\Collections\AbstractLazyCollection, Doctrine\Common\Collections\ArrayCollection, GuzzleHttp\Cookie\CookieJar, GuzzleHttp\Cookie\FileCookieJar, GuzzleHttp\Cookie\SessionCookieJar, PHPUnit\Framework\DataProviderTestSuite, PHPUnit\Framework\TestSuite, PharIo\Manifest\AuthorCollection, PharIo\Manifest\BundledComponentCollection, PharIo\Manifest\RequirementCollection, PhpCsFixer\Finder, SebastianBergmann\CodeCoverage\Node\Directory, Symfony\Component\Config\Resource\GlobResource, Symfony\Component\Console\Helper\HelperSet, Symfony\Component\Console\Helper\TableRows, Symfony\Component\Console\Tests\Helper\AutocompleteValues, Symfony\Component\EventDispatcher\GenericEvent, Symfony\Component\Finder\Finder, Symfony\Component\Finder\Iterator\SortableIterator, Symfony\Component\Finder\Tests\ClassThatInheritFinder, Symfony\Component\Process\InputStream, Symfony\Component\Process\PhpProcess, Symfony\Component\Process\Process, TestIteratorAggregate, TestIteratorAggregate2, WrapperIteratorAggregate, phpDocumentor\Reflection\Types\Compound.

        }

        $this->field = $field ?: $this->field;
    }

    public function accept()
    {
        $current = $this->getInnerIterator()->current();

        if ($current instanceof VatIdNoProviderInterface) {
            return !empty($current->getVatIdNo());
        } elseif (is_array($current)) {
            return array_key_exists($this->field, $current)
              and !empty($current[ $this->field ]);
        } elseif (is_object($current)) {
            return isset($current->{$this->field})
              and !empty($current->{$this->field});
        }
        return false;
    }
}