Germania\Users\PdoUserFactory

Complexity

Total Complexity

9

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Test Coverage

Coverage

85.19%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__debugInfo()	0	4	1
A	__construct()	0	27	3
A	has()	0	8	2
A	get()	0	13	3

<?php
namespace Germania\Users;

use Psr\Container\ContainerInterface;

class PdoUserFactory implements ContainerInterface
{

    /**
     * @var string
     */
    public $table = 'users';

    /**
     * @var string
     */
    public $users_class;


    /**
     * @var PDOStatement

The type Germania\Users\PDOStatement was not found. Did you mean PDOStatement? If so, make sure to prefix the type with \.

     */
    public $stmt;


    /**
     * @var PDO
     */
    public $pdo;


    /**
     * @param PDO           $pdo
     * @param UserAbstract  $user   Optional: User template object
     * @param string        $table  Optional: Users table name
     */
    public function __construct( \PDO $pdo, UserAbstract $user = null, $table = null )
    {
        $this->pdo             = $pdo;

It seems like $pdo of type PDO is incompatible with the declared type Germania\Users\PDO of property $pdo.

        $this->table           = $table ?: $this->table;
        $this->php_users_class = $user ? get_class($user) : User::class;

The property php_users_class does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // ID is listed twice here in order to use it with FETCH_UNIQUE as array key
        $sql = "SELECT DISTINCT
        U.id                 AS id,
        LOWER(HEX(U.uuid))   AS uuid,
        U.user_first_name    AS first_name,
        U.user_last_name     AS last_name,
        U.user_login_name    AS login_name,
        U.user_display_name  AS display_name,
        U.user_email         AS email,
        U.api_key            AS api_key

        FROM {$this->table} U

        WHERE U.id = :id
        AND   U.is_active > 0";

        $this->stmt = $pdo->prepare( $sql );

It seems like $pdo->prepare($sql) of type PDOStatement or boolean is incompatible with the declared type Germania\Users\PDOStatement of property $stmt.

        $this->stmt->setFetchMode( \PDO::FETCH_CLASS, $this->php_users_class );

$this->php_users_class of type string is incompatible with the type integer expected by parameter $columnNumber of PDOStatement::setFetchMode().

    }


    public function __debugInfo() {
        return [
            'DatabaseTable' => $this->table,
            'UsersPhpClass' => $this->php_users_class
        ];
    }



    public function has ($id) {
        if (!$this->stmt->execute([
            'id' => $id
        ])):
            throw new \RuntimeException("Could not read User from database");
        endif;

        return (bool) $this->stmt->fetch();
    }


    public function get ($id) {
        if (!$this->stmt->execute([
            'id' => $id
        ])):
            throw new \RuntimeException("Could not read User from database");
        endif;


        if ($user = $this->stmt->fetch()) {
            return $user;
        }

        throw new UserNotFoundException("Could not find User with ID '$id'");
    }

}