Germania\Salesmen\IteratorApplySalesman

Complexity

Total Complexity

4

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	2
A	__invoke()	0	14	2

<?php
namespace Germania\Salesmen;

/**
 * IteratorApplySalesman
 *
 * Usage:
 *
 *     <?php
 *     $salesman_name_factory = function( $retailer ) { return "First name" };
 *
 *     $retailers = new \ArrayIterator([ instance1, instance2 ]);
 *     iterator_apply($retailers, new IteratorApplySalesman( $salesman_name_factory ), [ $retailers ]);
 */
class IteratorApplySalesman
{

    /**
     * @var Callable
     */
    public $salesman_factory;


    /**
     * @var Callable
     */
    public $apply;


    /**
     * @param callable          $salesman_factory  Callable that takes a Salesman ID and returns a Salesman instance.
     * @param SalesmanInterface $salesman_fallback Optional SalesmanInterface fallback instance
     * @param callable          $apply             Optional Callable that takes the current item on iteration.
     */
    public function __construct( callable $salesman_factory, SalesmanInterface $salesman_fallback = null, callable $apply = null )
    {
        $this->salesman_factory = $salesman_factory;
        $this->apply = $apply ?: new ApplySalesman( $salesman_factory, $salesman_fallback );
    }


    /**
     * Must return TRUE, according to PHP's iterator_applay.
     *
     * @see  http://php.net/manual/de/function.iterator-apply.php
     */
    public function __invoke( \Traversable $iterator )
    {

        $current = ($iterator instanceOf \IteratorAggregate)
        ? $iterator->getIterator()->current()

It seems like you code against a concrete implementation and not the interface Traversable as the method current() does only exist in the following implementations of said interface: APCUIterator, AppendIterator, ArrayIterator, CachingIterator, CallbackFilterIterator, DirectoryIterator, EmptyIterator, File_Iterator, FilesystemIterator, FilterIterator, Generator, Germania\Retailers\RetailerFilterIterator, Germania\Salesmen\SalesmanFilterIterator, GlobIterator, Guzzle\Iterator\AppendIterator, Guzzle\Iterator\ChunkedIterator, Guzzle\Iterator\FilterIterator, Guzzle\Iterator\MapIterator, Guzzle\Iterator\MethodProxyIterator, Guzzle\Service\Resource\ResourceIterator, Guzzle\Tests\Service\Mock\Model\MockCommandIterator, HttpMessage, HttpRequestPool, Imagick, ImagickPixelIterator, InfiniteIterator, Issue523, IteratorIterator, LimitIterator, MongoCommandCursor, MongoCursor, MongoGridFSCursor, MultipleIterator, NoRewindIterator, PHPUnit\Framework\TestSuiteIterator, PHPUnit\Runner\Filter\ExcludeGroupFilterIterator, PHPUnit\Runner\Filter\GroupFilterIterator, PHPUnit\Runner\Filter\IncludeGroupFilterIterator, PHPUnit\Runner\Filter\NameFilterIterator, PHP_Token_Stream, ParentIterator, Phar, PharData, PharIo\Manifest\AuthorCollectionIterator, PharIo\Manifest\AuthorElementCollection, PharIo\Manifest\BundledComponentCollectionIterator, PharIo\Manifest\ComponentElementCollection, PharIo\Manifest\ElementCollection, PharIo\Manifest\ExtElementCollection, PharIo\Manifest\RequirementCollectionIterator, RecursiveArrayIterator, RecursiveCachingIterator, RecursiveCallbackFilterIterator, RecursiveDirectoryIterator, RecursiveFilterIterator, RecursiveIteratorIterator, RecursiveRegexIterator, RecursiveTreeIterator, RegexIterator, SQLiteResult, SebastianBergmann\CodeCoverage\Node\Iterator, SimpleXMLIterator, SplDoublyLinkedList, SplFileObject, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, SplTempFileObject, TestIterator, TestIterator2, TheSeer\Tokenizer\TokenCollection.

        : $iterator->current();

It seems like you code against a concrete implementation and not the interface Traversable as the method current() does only exist in the following implementations of said interface: APCUIterator, AppendIterator, ArrayIterator, CachingIterator, CallbackFilterIterator, DirectoryIterator, EmptyIterator, File_Iterator, FilesystemIterator, FilterIterator, Generator, Germania\Retailers\RetailerFilterIterator, Germania\Salesmen\SalesmanFilterIterator, GlobIterator, Guzzle\Iterator\AppendIterator, Guzzle\Iterator\ChunkedIterator, Guzzle\Iterator\FilterIterator, Guzzle\Iterator\MapIterator, Guzzle\Iterator\MethodProxyIterator, Guzzle\Service\Resource\ResourceIterator, Guzzle\Tests\Service\Mock\Model\MockCommandIterator, HttpMessage, HttpRequestPool, Imagick, ImagickPixelIterator, InfiniteIterator, Issue523, IteratorIterator, LimitIterator, MongoCommandCursor, MongoCursor, MongoGridFSCursor, MultipleIterator, NoRewindIterator, PHPUnit\Framework\TestSuiteIterator, PHPUnit\Runner\Filter\ExcludeGroupFilterIterator, PHPUnit\Runner\Filter\GroupFilterIterator, PHPUnit\Runner\Filter\IncludeGroupFilterIterator, PHPUnit\Runner\Filter\NameFilterIterator, PHP_Token_Stream, ParentIterator, Phar, PharData, PharIo\Manifest\AuthorCollectionIterator, PharIo\Manifest\AuthorElementCollection, PharIo\Manifest\BundledComponentCollectionIterator, PharIo\Manifest\ComponentElementCollection, PharIo\Manifest\ElementCollection, PharIo\Manifest\ExtElementCollection, PharIo\Manifest\RequirementCollectionIterator, RecursiveArrayIterator, RecursiveCachingIterator, RecursiveCallbackFilterIterator, RecursiveDirectoryIterator, RecursiveFilterIterator, RecursiveIteratorIterator, RecursiveRegexIterator, RecursiveTreeIterator, RegexIterator, SQLiteResult, SebastianBergmann\CodeCoverage\Node\Iterator, SimpleXMLIterator, SplDoublyLinkedList, SplFileObject, SplFixedArray, SplHeap, SplMaxHeap, SplMinHeap, SplObjectStorage, SplPriorityQueue, SplQueue, SplStack, SplTempFileObject, TestIterator, TestIterator2, TheSeer\Tokenizer\TokenCollection.

        // Perform
        $apply = $this->apply;
        $apply( $current );

        // Must return true for iterator_apply
        return true;
    }


}