ApplySalesman::__invoke() - Code Metrics - GermaniaKG/Salesmen - Measure and Improve Code Quality continuously with Scrutinizer

ApplySalesman::__invoke() A
last analyzed 2019-02-18 09:35 UTC

↳ Parent: ApplySalesman

Complexity

Conditions	4
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

Metric	Value
dl	0
loc	28
ccs	0
cts	10
cp	0
rs	9.472
c	0
b	0
f	0
cc	4
nc	6
nop	1
crap	20

<?php
namespace Germania\Salesmen;

class ApplySalesman
{

    /**
     * @var Callable
     */
    public $salesman_factory;

    /**
     * @var SalesmanInterface
     */
    public $salesman_fallback;


    /**
     * @param callable $salesman_factory Callable that takes a Salesman ID that should return a SalesmanInterface instance.
     */
    public function __construct( callable $salesman_factory, SalesmanInterface $salesman_fallback = null )
    {
        $this->salesman_factory  = $salesman_factory;
        $this->salesman_fallback = $salesman_fallback;
    }


    /**
     * @param  SalesmanIdProviderInterface|StdClass $aggregator Object that provides a salesman_id
     * @return bool
     */
    public function __invoke( $aggregator )
    {


        // Prepare callable
        $salesman_factory = $this->salesman_factory;


        // Add salesman proporty if not exists
        if (!isset($aggregator->salesman)):
            $aggregator->salesman = null;
        endif;


        // If salesman_id is available
        if ($aggregator instanceOf SalesmanIdProviderInterface):
            $aggregator->salesman = $salesman_factory( $aggregator->getSalesmanId(), $this->salesman_fallback );
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

        elseif (isset($aggregator->salesman_id)):
            $aggregator->salesman = $salesman_factory( $aggregator->salesman_id, $this->salesman_fallback );

        // Salesman can not be set
        else:
            return false;
        endif;

        return true;
    }
}


1			<?php
2			namespace Germania\Salesmen;
3
4			class ApplySalesman
5			{
6
7			/**
8			* @var Callable
9			*/
10			public $salesman_factory;
11
12			/**
13			* @var SalesmanInterface
14			*/
15			public $salesman_fallback;
16
17
18			/**
19			* @param callable $salesman_factory Callable that takes a Salesman ID that should return a SalesmanInterface instance.
20			*/
21			public function __construct( callable $salesman_factory, SalesmanInterface $salesman_fallback = null )
22			{
23			$this->salesman_factory = $salesman_factory;
24			$this->salesman_fallback = $salesman_fallback;
25			}
26
27
28			/**
29			* @param SalesmanIdProviderInterface\|StdClass $aggregator Object that provides a salesman_id
30			* @return bool
31			*/
32			public function __invoke( $aggregator )
33			{
34
35
36			// Prepare callable
37			$salesman_factory = $this->salesman_factory;
38
39
40			// Add salesman proporty if not exists
41			if (!isset($aggregator->salesman)):
42			$aggregator->salesman = null;
43			endif;
44
45
46			// If salesman_id is available
47			if ($aggregator instanceOf SalesmanIdProviderInterface):
48			$aggregator->salesman = $salesman_factory( $aggregator->getSalesmanId(), $this->salesman_fallback );
			0 ignored issues – show Bug introduced 2018-02-08 12:26 UTC by Report Bug Copy Issue Report Accessing `salesman` on the interface `Germania\Salesmen\SalesmanIdProviderInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
49
50			elseif (isset($aggregator->salesman_id)):
51			$aggregator->salesman = $salesman_factory( $aggregator->salesman_id, $this->salesman_fallback );
52
53			// Salesman can not be set
54			else:
55			return false;
56			endif;
57
58			return true;
59			}
60			}
61

GermaniaKG / Salesmen

ApplySalesman::__invoke() A last analyzed 2019-02-18 09:35 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like

ApplySalesman::__invoke() A
last analyzed 2019-02-18 09:35 UTC