Issues in PdoUpdatePermissionRoles.php (master) - Issues in master - GermaniaKG/Permissions - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/PdoUpdatePermissionRoles.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Germania\Permissions;

use Psr\Log\LoggerInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;

class PdoUpdatePermissionRoles
{

    use LoggerAwareTrait;

    public $permissions;

    /**
     * @var \PDO
     */
    public $pdo;

    /**
     * @var \PDOStatement
     */
    public $stmt;

    /**
     * @var string
     */
    public $permissions_table = "permissions";

    /**
     * @var string
     */
    public $permissions_roles_table = "permissions_roles";

    /**
     * @var Seperator string for roles in SELECT statement
     */
    protected $separator = ",";


    /**
     * @var PdoAssignRoleToPermission
     */
    public $assigner;

    /**
     * @var PdoAssignRoleToPermission
     */
    public $unassigner;



    /**
     * @param \PDO                 $pdo                      PDO instance
     * @param string               $permissions_table        Permissions table name
     * @param string               $permissions_roles_table  Permissions/Roles table name
     * @param LoggerInterface|null $logger                   Optional: PSR-3 Logger
     */
    public function __construct( \PDO $pdo, $permissions_table, $permissions_roles_table, LoggerInterface $logger = null )
    {
        $this->setLogger( $logger ?: new NullLogger );

        // Prerequisites
        $this->pdo                     = $pdo;
        $this->permissions_table       = $permissions_table;
        $this->permissions_roles_table = $permissions_roles_table;


        $this->assigner    = new PdoAssignRoleToPermission( $pdo, $permissions_roles_table, $logger);
        $this->unassigner  = new PdoUnassignRoleFromPermission( $pdo, $permissions_roles_table, $logger);

        $this->permissions = new PdoAllPermissions($pdo, $permissions_table, $permissions_roles_table, $logger);
    }


    /**
     * @return int Last Insert ID or FALSE when something errored
     * @throws PermissionNameExistsException On duplicate name
     */
    public function __invoke( $permission_name, $role_ids )
    {

        try {
            $permission = $this->permissions->get( $permission_name );
        }
        catch (PermissionNotFoundException $e) {
            throw $e;
        }


        $permission_id  = $permission['id'];
        $assigned_roles = explode( $this->separator, $permission['assigned_roles']);

        $assigner   = $this->assigner;
        $unassigner = $this->unassigner;

        $to_add = array_diff($role_ids, $assigned_roles);
        foreach( $to_add as $role_id):
            try {
                $assigner( $permission_id, $role_id);
            }
            catch (RolePermissionAssignmentExistsException $e) {
                // noop
            }
        endforeach;


        $to_remove = array_diff($assigned_roles, $role_ids);
        foreach( $to_remove as $role_id):
            $unassigner( $permission_id, $role_id);
        endforeach;

        return true;
    }
}


1			<?php
2			namespace Germania\Permissions;
3
4			use Psr\Log\LoggerInterface;
5			use Psr\Log\LoggerAwareTrait;
6			use Psr\Log\NullLogger;
7
8			class PdoUpdatePermissionRoles
9			{
10
11			use LoggerAwareTrait;
12
13			public $permissions;
14
15			/**
16			* @var \PDO
17			*/
18			public $pdo;
19
20			/**
21			* @var \PDOStatement
22			*/
23			public $stmt;
24
25			/**
26			* @var string
27			*/
28			public $permissions_table = "permissions";
29
30			/**
31			* @var string
32			*/
33			public $permissions_roles_table = "permissions_roles";
34
35			/**
36			* @var Seperator string for roles in SELECT statement
37			*/
38			protected $separator = ",";
39
40
41			/**
42			* @var PdoAssignRoleToPermission
43			*/
44			public $assigner;
45
46			/**
47			* @var PdoAssignRoleToPermission
48			*/
49			public $unassigner;
50
51
52
53			/**
54			* @param \PDO $pdo PDO instance
55			* @param string $permissions_table Permissions table name
56			* @param string $permissions_roles_table Permissions/Roles table name
57			* @param LoggerInterface\|null $logger Optional: PSR-3 Logger
58			*/
59			public function __construct( \PDO $pdo, $permissions_table, $permissions_roles_table, LoggerInterface $logger = null )
60			{
61			$this->setLogger( $logger ?: new NullLogger );
62
63			// Prerequisites
64			$this->pdo = $pdo;
65			$this->permissions_table = $permissions_table;
66			$this->permissions_roles_table = $permissions_roles_table;
67
68
69			$this->assigner = new PdoAssignRoleToPermission( $pdo, $permissions_roles_table, $logger);
70			$this->unassigner = new PdoUnassignRoleFromPermission( $pdo, $permissions_roles_table, $logger);
			0 ignored issues – show Documentation Bug introduced 2018-07-09 13:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `new \Germania\Permission...s_roles_table, $logger)` of type `object<Germania\Permissi...signRoleFromPermission>` is incompatible with the declared type `object<Germania\Permissi...AssignRoleToPermission>` of property `$unassigner`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
71			$this->permissions = new PdoAllPermissions($pdo, $permissions_table, $permissions_roles_table, $logger);
72			}
73
74
75			/**
76			* @return int Last Insert ID or FALSE when something errored
77			* @throws PermissionNameExistsException On duplicate name
78			*/
79			public function __invoke( $permission_name, $role_ids )
80			{
81
82			try {
83			$permission = $this->permissions->get( $permission_name );
84			}
85			catch (PermissionNotFoundException $e) {
86			throw $e;
87			}
88
89
90			$permission_id = $permission['id'];
91			$assigned_roles = explode( $this->separator, $permission['assigned_roles']);
92
93			$assigner = $this->assigner;
94			$unassigner = $this->unassigner;
95
96			$to_add = array_diff($role_ids, $assigned_roles);
97			foreach( $to_add as $role_id):
98			try {
99			$assigner( $permission_id, $role_id);
100			}
101			catch (RolePermissionAssignmentExistsException $e) {
102			// noop
103			}
104			endforeach;
105
106
107			$to_remove = array_diff($assigned_roles, $role_ids);
108			foreach( $to_remove as $role_id):
109			$unassigner( $permission_id, $role_id);
110			endforeach;
111
112			return true;
113			}
114			}
115

GermaniaKG / Permissions

Issues (3)

Security Analysis no request data

src/PdoUpdatePermissionRoles.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like