Issues in PaginationFactory.php (master) - Issues in master - GermaniaKG/Pagination - Measure and Improve Code Quality continuously with Scrutinizer

Issues (10)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/PaginationFactory.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Germania\Pagination;

class PaginationFactory
{


	/**
	 * @var int
	 */
	public $default_page_size = 25;


	/**
	 * Default class FQDN for creating the Pagination instance 
	 * @var string
	 */
	public $default_pagination_class;



	/**
	 * @param int|integer $default_page_size Default: 25
	 * @param string|null $php_class         Default: \Germania\Pagination\Pagination
	 */
	public function __construct( int $default_page_size = 25, string $php_class = null )
	{
		$this->default_page_size = $default_page_size;
		$this->default_pagination_class = $php_class ?: Pagination::class;
	}


	/**
	 * @param  mixed        $items            The items to paginate: int, array or Traversable (countable)
	 * @param  int|array    $pagination_data  The data to construct the pagination with
	 * @param  string       $php_class        Optional: Custom pagination class FQDN
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return 
	 */
	public function __invoke( $items, $pagination_data, string $custom_php_class = null )
	{
		$items_count = $this->countItems( $items );

		$klasse = $custom_php_class ?: $this->default_pagination_class;
		$pagination = new $klasse( $items_count, $this->default_page_size );


		// Eval user data
        if (is_numeric($pagination_data)):
            $pagination->setCurrent( $pagination_data );

        elseif (is_array($pagination_data)):
            if (!empty($pagination_data['size'])):
            	$pagination->setPageSize( $pagination_data['size'] );
            endif;

            $pagination->setCurrent( $pagination_data['number'] ?? 0);

        else:
        	throw new PaginationInvalidArgumentException("Integer or Array expected");

        endif;
		return $pagination;
	}


	/**
	 * Counts the items to determine the $items_count parameter for Pagination class.
	 * 
	 * @param   mixed $items
	 * @return  int
	 * @throws  PaginationInvalidArgumentException
	 */
	protected function countItems( $items )
	{
		if (is_array($items)):
			return count($items);

		elseif ($items instanceOf \Countable):
			return count($items);

		elseif ($items instanceOf \Traversable):
			return iterator_count($items);

		elseif (is_int($items)):
			return $items;

		else:
			throw new PaginationInvalidArgumentException("Countable, Traversable or integer expected");
		endif;

	}
}

1		<?php
2		namespace Germania\Pagination;
3
4		class PaginationFactory
5		{
6
7
8		/**
9		* @var int
10		*/
11		public $default_page_size = 25;
12
13
14		/**
15		* Default class FQDN for creating the Pagination instance
16		* @var string
17		*/
18		public $default_pagination_class;
19
20
21
22		/**
23		* @param int\|integer $default_page_size Default: 25
24		* @param string\|null $php_class Default: \Germania\Pagination\Pagination
25		*/
26	88	public function __construct( int $default_page_size = 25, string $php_class = null )
27		{
28	88	$this->default_page_size = $default_page_size;
29	88	$this->default_pagination_class = $php_class ?: Pagination::class;
30	88	}
31
32
33		/**
34		* @param mixed $items The items to paginate: int, array or Traversable (countable)
35		* @param int\|array $pagination_data The data to construct the pagination with
36		* @param string $php_class Optional: Custom pagination class FQDN
		0 ignored issues – show Documentation introduced 2019-03-14 11:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$php_class`. Did you maybe mean `$custom_php_class`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
37		* @return
38		*/
39	48	public function __invoke( $items, $pagination_data, string $custom_php_class = null )
40		{
41	48	$items_count = $this->countItems( $items );
42
43	44	$klasse = $custom_php_class ?: $this->default_pagination_class;
44	44	$pagination = new $klasse( $items_count, $this->default_page_size );
45
46
47		// Eval user data
48	44	if (is_numeric($pagination_data)):
49	20	$pagination->setCurrent( $pagination_data );
50
51	24	elseif (is_array($pagination_data)):
52	20	if (!empty($pagination_data['size'])):
53	8	$pagination->setPageSize( $pagination_data['size'] );
54		endif;
55
56	20	$pagination->setCurrent( $pagination_data['number'] ?? 0);
57
58		else:
59	4	throw new PaginationInvalidArgumentException("Integer or Array expected");
60
61		endif;
62	40	return $pagination;
63		}
64
65
66		/**
67		* Counts the items to determine the $items_count parameter for Pagination class.
68		*
69		* @param mixed $items
70		* @return int
71		* @throws PaginationInvalidArgumentException
72		*/
73	48	protected function countItems( $items )
74		{
75	48	if (is_array($items)):
76	8	return count($items);
77
78	40	elseif ($items instanceOf \Countable):
79	28	return count($items);
80
81	12	elseif ($items instanceOf \Traversable):
82	4	return iterator_count($items);
83
84	8	elseif (is_int($items)):
85	4	return $items;
86
87		else:
88	4	throw new PaginationInvalidArgumentException("Countable, Traversable or integer expected");
89		endif;
90
91		}
92		}

GermaniaKG / Pagination

Issues (10)

Security Analysis no request data

src/PaginationFactory.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like