Germania\Coupons\PdoCouponsFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	61
Duplicated Lines	36.07 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	22	22	3
A	__invoke()	0	13	3

<?php
namespace Germania\Coupons;

class PdoCouponsFactory
{

    /**
     * @var string
     */
    public $php_class;


    /**
     * @var PDOStatement
     */
    public $stmt;

    /**
     * @param \PDO   $pdo
     * @param string $coupons_table
     * @param string $php_class
     */
    public function __construct( \PDO $pdo, $coupons_table, $php_class = null)

This method seems to be duplicated in your project.

    {
        $this->php_class = $php_class ?: Coupon::class;

        if (!is_subclass_of($this->php_class, CouponInterface::class ))

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Germania\Coupons\CouponInterface::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new \InvalidArgumentException("Class name or instance of CouponInterface expected.");

        $sql = "SELECT
        -- id field twice here due to FETCH_UNIQUE
        id,
        id,
        code,
        coupon_sheet_id

        FROM `{$coupons_table}`

        WHERE coupon_sheet_id = :sheet_id";

        $this->stmt = $pdo->prepare( $sql );

It seems like $pdo->prepare($sql) of type object<PDOStatement> is incompatible with the declared type object<Germania\Coupons\PDOStatement> of property $stmt.

        $this->stmt->setFetchMode( \PDO::FETCH_CLASS, $this->php_class );

    }

    /**
     * @param  int|CouponSheetInterface $sheet_id
     * @return CouponInterface[]
     */
    public function __invoke( $sheet_id )
    {
        if ($sheet_id instanceOf CouponSheetInterface)
            $sheet_id = $sheet_id->getId();

        if (!$this->stmt->execute([
            'sheet_id' => $sheet_id
        ])) {
            throw new \RuntimeException("Could not execute PDOStatement.");
        }
        return $this->stmt->fetchAll(\PDO::FETCH_UNIQUE );

    }

}