Germania\Coupons\PdoCouponSheetFactory

Complexity

Total Complexity

5

Size/Duplication

Total Lines	65
Duplicated Lines	44.62 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

0%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	29	29	3
A	__invoke()	0	10	2

<?php
namespace Germania\Coupons;

class PdoCouponSheetFactory
{

    /**
     * @var string
     */
    public $php_class;

    /**
     * @var PDOStatement
     */
    public $stmt;

    /**
     * @param \PDO   $pdo
     * @param string $sheets_table
     * @param string $coupons_table
     * @param string $php_class
     */
    public function __construct( \PDO $pdo, $sheets_table, $coupons_table, $php_class = null)

This method seems to be duplicated in your project.

    {
        $this->php_class = $php_class ?: CouponSheet::class;

        if (!is_subclass_of($this->php_class, CouponSheetInterface::class ))

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Germania\Coupons\CouponSheetInterface::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            throw new \InvalidArgumentException("Class name or instance of CouponSheetInterface expected.");

        $sql = "SELECT
        Sheets.id,
        Sheets.slug,
        Sheets.name,
        Sheets.quantity,
        Sheets.valid_from,
        Sheets.valid_until,
        GROUP_CONCAT(Coupons.code) AS coupons

        FROM `{$sheets_table}` Sheets

        RIGHT JOIN `{$coupons_table}` Coupons
        ON Coupons.coupon_sheet_id = Sheets.id

        WHERE Sheets.id   = :id
        OR    Sheets.slug = :id
        LIMIT 1";

        $this->stmt = $pdo->prepare( $sql );

It seems like $pdo->prepare($sql) of type object<PDOStatement> is incompatible with the declared type object<Germania\Coupons\PDOStatement> of property $stmt.

        $this->stmt->setFetchMode( \PDO::FETCH_CLASS, $this->php_class );

    }

    /**
     * @param  string|int $id
     * @return CouponSheet|null
     */
    public function __invoke( $id )
    {
        if (!$this->stmt->execute([
            'id' => $id
        ])) {
            throw new \RuntimeException("Could not execute PDOStatement.");
        }

        return $this->stmt->fetch();
    }

}