Germania\Coupons\CouponSheet

Complexity

Total Complexity

20

Size/Duplication

Total Lines	143
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	2

Test Coverage

Coverage

93.62%

Importance

Changes

0

10 Methods

Rating	Name	Duplication	Size	Complexity
A	setId()	0	4	1
A	setQuantity()	0	4	1
A	setSlug()	0	4	1
A	setName()	0	4	1
A	setValidFrom()	0	4	1
A	getValidFrom()	0	6	3
A	setValidUntil()	0	4	1
A	getValidUntil()	0	7	3
A	getCoupons()	0	6	3
A	setCoupons()	0	22	5

<?php
namespace Germania\Coupons;

class CouponSheet extends CouponSheetAbstract implements CouponSheetInterface
{

    /**
     * @param  string $id
     * @return self Fluid Interface
     */
    public function setId( $id ) {
        $this->id = $id;
        return $this;
    }


    /**
     * @param  int $quantity
     * @return self Fluid Interface
     */
    public function setQuantity( $quantity ) {
        $this->quantity = $quantity;
        return $this;
    }


    /**
     * @param string $id

There is no parameter named $id. Was it maybe removed?

     * @return self Fluid Interface
     */
    public function setSlug( $slug ) {
        $this->slug = $slug;
        return $this;
    }


    /**
     * @param string $id

There is no parameter named $id. Was it maybe removed?

     * @return self Fluid Interface
     */
    public function setName( $name ) {
        $this->name = $name;
        return $this;
    }





    /**
     * @param DateTimeInterface $valid_from
     * @return self Fluid Interface
     */
    public function setValidFrom( \DateTimeInterface $valid_from ) {
        $this->valid_from = $valid_from;

It seems like $valid_from of type object<DateTimeInterface> is incompatible with the declared type object<Germania\Coupons\DateTime>|null of property $valid_from.

        return $this;
    }


    /**
     * @inheritdoc
     *
     * If the valid_from value is a datetime string (like "Y-m-d H:i:s"),
     * the value will be converted to a DateTime object.
     *
     * @return DateTime
     * @implements CouponSheetInterface
     */
    public function getValidFrom() {
        if ($this->valid_from and is_string($this->valid_from)):
            $this->setValidFrom( \DateTime::createFromFormat("Y-m-d H:i:s", $this->valid_from) );

It seems like \DateTime::createFromFormat('Y-m-d H:i:s', $this->valid_from) targeting DateTime::createFromFormat() can also be of type false; however, Germania\Coupons\CouponSheet::setValidFrom() does only seem to accept object<DateTimeInterface>, did you maybe forget to handle an error condition?

        endif;
        return $this->valid_from;

The expression $this->valid_from; of type null|Germania\Coupons\DateTime|string adds the type string to the return on line 73 which is incompatible with the return type declared by the interface Germania\Coupons\CouponSheetInterface::getValidFrom of type Germania\Coupons\DateTime.

    }



    /**
     * @param DateTimeInterface $valid_until
     * @return self Fluid Interface
     */
    public function setValidUntil( \DateTimeInterface $valid_until ) {
        $this->valid_until = $valid_until;

It seems like $valid_until of type object<DateTimeInterface> is incompatible with the declared type object<Germania\Coupons\DateTime>|null of property $valid_until.

        return $this;
    }

    /**
     * @inheritdoc
     *
     * If the valid_until value is a datetime string (like "Y-m-d H:i:s"),
     * the value will be converted to a DateTime object.
     *
     * @return DateTime
     * @implements CouponSheetInterface
     */
    public function getValidUntil() {
        if ($this->valid_until and is_string($this->valid_until)):
            $this->setValidUntil( \DateTime::createFromFormat("Y-m-d H:i:s", $this->valid_until) );

It seems like \DateTime::createFromFormat('Y-m-d H:i:s', $this->valid_until) targeting DateTime::createFromFormat() can also be of type false; however, Germania\Coupons\CouponSheet::setValidUntil() does only seem to accept object<DateTimeInterface>, did you maybe forget to handle an error condition?

        endif;

        return $this->valid_until;

The expression $this->valid_until; of type null|Germania\Coupons\DateTime|string adds the type string to the return on line 101 which is incompatible with the return type declared by the interface Germania\Coupons\CouponSheetInterface::getValidUntil of type Germania\Coupons\DateTime.

    }



    /**
     * @return CouponInterface[]
     * @implements CouponSheetInterface
     */
    public function getCoupons() {
        if ($this->coupons and is_string( $this->coupons ))
            $this->setCoupons( $this->coupons );

$this->coupons is of type string, but the function expects a array|object<Traversable>.

        return $this->coupons;

The return type of return $this->coupons; (string) is incompatible with the return type declared by the interface Germania\Coupons\CouponSheetInterface::getCoupons of type Germania\Coupons\CouponInterface[].

    }


    /**
     * @param array|\Traversable $coupons
     * @return self Fluid Interface
     */
    public function setCoupons( $coupons )
    {
        if ($coupons instanceOf \Traversable ):
            $coupons = iterator_to_array( $coupons, "use_keys");

        elseif (is_string( $coupons )):
            $instances = array();
            foreach(explode(",", $coupons) as $raw_coupon)
                array_push($instances, Coupon::fromArray([
                    'code' => $raw_coupon,
                    'coupon_sheet' => $this
                ]));
            $coupons = $instances;

        elseif (!is_array( $coupons )):
            throw new \InvalidArgumentException("Array or Traversable expected");

        endif;

        $this->coupons = $coupons;

It seems like $coupons of type array is incompatible with the declared type string of property $coupons.

        return $this;
    }


}