PdoAddressUpdater::__construct() - Code Metrics - Inspection of "Merge branch 'release/1.2.3'" - GermaniaKG/Addresses - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 982641...a62c86 )

by Carsten

created 2019-10-07 10:58 UTC

PdoAddressUpdater::__construct() A

↳ Parent: PdoAddressUpdater

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	16
ccs	4
cts	4
cp	1
rs	9.7333
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	1

<?php
namespace Germania\Addresses;

class PdoAddressUpdater
{
	/**
	 * @var PDOStmt
	 */
	public $stmt; 


	/**
	 * @param \PDO                $pdo
	 * @param string              $table_name
	 */
	public function __construct( \PDO $pdo, string $table_name )
	{

		$sql = "UPDATE {$table_name} 
		SET
		type     = :type,
		street1  = :street1,
		street2  = :street2,
		zip      = :zip,
		location = :location,
		country  = :country
		WHERE id = :id
		LIMIT 1";

		$this->stmt = $pdo->prepare( $sql );

	}



	public function __invoke( PdoAddressInterface $address ) : int
	{
		if (!$id = $address->getId())
			throw new \UnexpectedValueException("Addess object 'getId' did not return primary key value");

		$result = $this->stmt->execute([
			'id'       => $id,
			'type'     => $address->getType(),
			'street1'  => $address->getStreet1(),
			'street2'  => $address->getStreet2(),
			'zip'      => $address->getZip(),
			'location' => $address->getLocation(),
			'country'  => $address->getCountry()
		]);

		if (!$result) {
			$msg = sprintf("Could not execute PDOStatement for address ID '%s'", $id);
			throw new \RuntimeException($msg);
		}

		return $this->stmt->rowCount();
	}
}

1		<?php
2		namespace Germania\Addresses;
3
4		class PdoAddressUpdater
5		{
6		/**
7		* @var PDOStmt
8		*/
9		public $stmt;
10
11
12		/**
13		* @param \PDO $pdo
14		* @param string $table_name
15		*/
16	6	public function __construct( \PDO $pdo, string $table_name )
17		{
18
19	6	$sql = "UPDATE {$table_name}
20		SET
21		type = :type,
22		street1 = :street1,
23		street2 = :street2,
24		zip = :zip,
25		location = :location,
26		country = :country
27		WHERE id = :id
28		LIMIT 1";
29
30	6	$this->stmt = $pdo->prepare( $sql );
		0 ignored issues – show Documentation Bug introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report It seems like `$pdo->prepare($sql)` of type `object<PDOStatement>` is incompatible with the declared type `object<Germania\Addresses\PDOStmt>` of property `$stmt`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31	6	}
32
33
34
35	6	public function __invoke( PdoAddressInterface $address ) : int
36		{
37	6	if (!$id = $address->getId())
38	2	throw new \UnexpectedValueException("Addess object 'getId' did not return primary key value");
39
40	4	$result = $this->stmt->execute([
41	4	'id' => $id,
42	4	'type' => $address->getType(),
43	4	'street1' => $address->getStreet1(),
44	4	'street2' => $address->getStreet2(),
45	4	'zip' => $address->getZip(),
46	4	'location' => $address->getLocation(),
47	4	'country' => $address->getCountry()
48		]);
49
50	4	if (!$result) {
51	2	$msg = sprintf("Could not execute PDOStatement for address ID '%s'", $id);
52	2	throw new \RuntimeException($msg);
53		}
54
55	2	return $this->stmt->rowCount();
56		}
57		}

GermaniaKG / Addresses

Push — master ( 982641...a62c86 )

PdoAddressUpdater::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like