PdoAddressUpdater::__invoke() - Code Metrics - Inspection of "Merge branch 'release/1.2.0'" - GermaniaKG/Addresses - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( eb1d05...b38a80 )

by Carsten

created 2019-10-07 09:01 UTC

PdoAddressUpdater::__invoke() A

↳ Parent: PdoAddressUpdater

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	0
cts	15
cp	0
rs	9.568
c	0
b	0
f	0
cc	3
nc	3
nop	1
crap	12

<?php
namespace Germania\Addresses;

class PdoAddressUpdater
{
	/**
	 * @var PDOStmt
	 */
	public $stmt; 


	/**
	 * @param \PDO                $pdo
	 * @param string              $table_name
	 */
	public function __construct( \PDO $pdo, string $table_name )
	{

		$sql = "UPDATE {$table_name} 
		SET
		type     = :type,
		street1  = :street1,
		street2  = :street2,
		zip      = :zip,
		location = :location,
		country  = :country
		WHERE id = :id
		LIMIT 1";

		$this->stmt = $pdo->prepare( $sql );

	}



	public function __invoke( PdoAddressInterface $address ) : int
	{
		if (!$id = $address->getId())
			throw new \UnexpectedValueException("Addess object 'getId' did not return primary key value");

		$result = $this->stmt->execute([
			'id'       => $id,
			'type'     => $address->getType(),
			'street1'  => $address->getStreet1(),
			'street2'  => $address->getStreet2(),
			'zip'      => $address->getZip(),
			'location' => $address->getLocation(),
			'country'  => $address->getCountry()
		]);

		if (!$result) {
			$msg = sprintf("Could not execute PDOStatement for address ID '%s'", $id);
			throw new \RuntimeException($msg);
		}

		return $this->stmt->rowCount();
	}
}

1			<?php
2			namespace Germania\Addresses;
3
4			class PdoAddressUpdater
5			{
6			/**
7			* @var PDOStmt
8			*/
9			public $stmt;
10
11
12			/**
13			* @param \PDO $pdo
14			* @param string $table_name
15			*/
16			public function __construct( \PDO $pdo, string $table_name )
17			{
18
19			$sql = "UPDATE {$table_name}
20			SET
21			type = :type,
22			street1 = :street1,
23			street2 = :street2,
24			zip = :zip,
25			location = :location,
26			country = :country
27			WHERE id = :id
28			LIMIT 1";
29
30			$this->stmt = $pdo->prepare( $sql );
			0 ignored issues – show Documentation Bug introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report It seems like `$pdo->prepare($sql)` of type `object<PDOStatement>` is incompatible with the declared type `object<Germania\Addresses\PDOStmt>` of property `$stmt`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
31			}
32
33
34
35			public function __invoke( PdoAddressInterface $address ) : int
36			{
37			if (!$id = $address->getId())
38			throw new \UnexpectedValueException("Addess object 'getId' did not return primary key value");
39
40			$result = $this->stmt->execute([
41			'id' => $id,
42			'type' => $address->getType(),
43			'street1' => $address->getStreet1(),
44			'street2' => $address->getStreet2(),
45			'zip' => $address->getZip(),
46			'location' => $address->getLocation(),
47			'country' => $address->getCountry()
48			]);
49
50			if (!$result) {
51			$msg = sprintf("Could not execute PDOStatement for address ID '%s'", $id);
52			throw new \RuntimeException($msg);
53			}
54
55			return $this->stmt->rowCount();
56			}
57			}

GermaniaKG / Addresses

Push — master ( eb1d05...b38a80 )

PdoAddressUpdater::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like