PdoAddressInserter::__construct() - Code Metrics - Inspection of "Merge branch 'release/1.2.0'" - GermaniaKG/Addresses - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( eb1d05...b38a80 )

by Carsten

created 2019-10-07 09:01 UTC

PdoAddressInserter::__construct() A

↳ Parent: PdoAddressInserter

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	0
cts	5
cp	0
rs	9.9332
c	0
b	0
f	0
cc	1
nc	1
nop	2
crap	2

<?php
namespace Germania\Addresses;

class PdoAddressInserter
{
	/**
	 * @var PDOStmt
	 */
	public $stmt; 

	/**
	 * @var PDO
	 */
	public $pdo; 


	/**
	 * @param \PDO                $pdo
	 * @param string              $table_name
	 */
	public function __construct( \PDO $pdo, string $table_name )
	{
		$this->pdo = $pdo;


		$sql = "INSERT INTO {$table_name} 
		( type, street1, street2, zip, location, country )
		VALUES( :type, :street1, :street2, :zip, :location, :country)";

		$this->stmt = $pdo->prepare( $sql );

	}



	public function __invoke( AddressInterface $address ) : int
	{
		$result = $this->stmt->execute([
			'type'     => $address->getType(),
			'street1'  => $address->getStreet1(),
			'street2'  => $address->getStreet2(),
			'zip'      => $address->getZip(),
			'location' => $address->getLocation(),
			'country'  => $address->getCountry()
		]);

		if (!$result) {
			$msg = sprintf("Could not execute PDOStatement for inserting address");
			throw new \RuntimeException($msg);
		}

		return $this->pdo->lastInsertId();
	}
}

1			<?php
2			namespace Germania\Addresses;
3
4			class PdoAddressInserter
5			{
6			/**
7			* @var PDOStmt
8			*/
9			public $stmt;
10
11			/**
12			* @var PDO
13			*/
14			public $pdo;
15
16
17			/**
18			* @param \PDO $pdo
19			* @param string $table_name
20			*/
21			public function __construct( \PDO $pdo, string $table_name )
22			{
23			$this->pdo = $pdo;
			0 ignored issues – show Documentation Bug introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report It seems like `$pdo` of type `object<PDO>` is incompatible with the declared type `object<Germania\Addresses\PDO>` of property `$pdo`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
24
25			$sql = "INSERT INTO {$table_name}
26			( type, street1, street2, zip, location, country )
27			VALUES( :type, :street1, :street2, :zip, :location, :country)";
28
29			$this->stmt = $pdo->prepare( $sql );
			0 ignored issues – show Documentation Bug introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report It seems like `$pdo->prepare($sql)` of type `object<PDOStatement>` is incompatible with the declared type `object<Germania\Addresses\PDOStmt>` of property `$stmt`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
30			}
31
32
33
34			public function __invoke( AddressInterface $address ) : int
35			{
36			$result = $this->stmt->execute([
37			'type' => $address->getType(),
38			'street1' => $address->getStreet1(),
39			'street2' => $address->getStreet2(),
40			'zip' => $address->getZip(),
41			'location' => $address->getLocation(),
42			'country' => $address->getCountry()
43			]);
44
45			if (!$result) {
46			$msg = sprintf("Could not execute PDOStatement for inserting address");
47			throw new \RuntimeException($msg);
48			}
49
50			return $this->pdo->lastInsertId();
51			}
52			}

GermaniaKG / Addresses

Push — master ( eb1d05...b38a80 )

PdoAddressInserter::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like