PdoAddressFactory::__invoke() - Code Metrics - Inspection of "Merge branch 'release/1.2.0'" - GermaniaKG/Addresses - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( eb1d05...b38a80 )

by Carsten

created 2019-10-07 09:01 UTC

PdoAddressFactory::__invoke() A

↳ Parent: PdoAddressFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	6

<?php
namespace Germania\Addresses;

class PdoAddressFactory
{
	/**
	 * @var AddressFactory
	 */
	public $address_factory; 	


	/**
	 * @var PDOStmt
	 */
	public $stmt; 

	public static $DB_FIELDS = array(
		'id',
		'type',
		'street1',
		'street2',
		'zip',
		'location',
		'country'
	);

	/**
	 * @param \PDO                $pdo
	 * @param string              $table_name
	 * @param AddressFactory|null $address_factory
	 */
	public function __construct( \PDO $pdo, string $table_name, AddressFactory $address_factory = null )
	{
		$this->address_factory = $address_factory ?: new AddressFactory;

		$sql = "SELECT " . implode(",", static::$DB_FIELDS) ."
		FROM {$table_name}
		WHERE id = :id";

		$this->stmt = $pdo->prepare( $sql );

		$this->stmt->setFetchMode(\PDO::FETCH_CLASS, PdoAddress::class);
	}


	public function __invoke( int $id ) : AddressInterface
	{
		if (!$this->stmt->execute(['id' => $id]))
			throw new \RuntimeException("Could not execute SELECT Address PDOStatement");

		return $this->stmt->fetch();
	}
}

1			<?php
2			namespace Germania\Addresses;
3
4			class PdoAddressFactory
5			{
6			/**
7			* @var AddressFactory
8			*/
9			public $address_factory;
			0 ignored issues – show Coding Style introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report There is some trailing whitespace on this line which should be avoided as per coding-style. Loading history...
10
11			/**
12			* @var PDOStmt
13			*/
14			public $stmt;
15
16			public static $DB_FIELDS = array(
17			'id',
18			'type',
19			'street1',
20			'street2',
21			'zip',
22			'location',
23			'country'
24			);
25
26			/**
27			* @param \PDO $pdo
28			* @param string $table_name
29			* @param AddressFactory\|null $address_factory
30			*/
31			public function __construct( \PDO $pdo, string $table_name, AddressFactory $address_factory = null )
32			{
33			$this->address_factory = $address_factory ?: new AddressFactory;
34
35			$sql = "SELECT " . implode(",", static::$DB_FIELDS) ."
36			FROM {$table_name}
37			WHERE id = :id";
38
39			$this->stmt = $pdo->prepare( $sql );
			0 ignored issues – show Documentation Bug introduced 2019-10-07 09:03 UTC by Report Bug Copy Issue Report It seems like `$pdo->prepare($sql)` of type `object<PDOStatement>` is incompatible with the declared type `object<Germania\Addresses\PDOStmt>` of property `$stmt`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
40			$this->stmt->setFetchMode(\PDO::FETCH_CLASS, PdoAddress::class);
41			}
42
43
44			public function __invoke( int $id ) : AddressInterface
45			{
46			if (!$this->stmt->execute(['id' => $id]))
47			throw new \RuntimeException("Could not execute SELECT Address PDOStatement");
48
49			return $this->stmt->fetch();
50			}
51			}

GermaniaKG / Addresses

Push — master ( eb1d05...b38a80 )

PdoAddressFactory::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like