Germania\Addresses\AddressFactory

Complexity

Total Complexity

8

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	__invoke()	0	5	1
A	apply()	0	27	5

<?php
namespace Germania\Addresses;


/**
 * Creates AddressInterface instances from an associative array.
 *
 * Example:
 *
 *     <?php
 *     $factory = (new AddressFactory)([
 *       'street1'  => 'Street name 1',
 *       'street2'  => null,
 *       'zip'      => 'DG2JQ',
 *       'location' => 'Dumfries',
 *       'country'  => 'Scotland'
 *     ]);
 *
 */
class AddressFactory
{
    public $php_address_class;

    public $default_data = array(
        'type'     => null,
        'street1'  => null,
        'street2'  => null,
        'zip'      => null,
        'location' => null,
        'country'  => null,
    );

    /**
     * @param string|null $address_class
     */
    public function __construct(string $address_class = null)
    {
        $this->php_address_class = $address_class ?: Address::class ;
    }


    /**
     * @param  array  $address_data
     * @return AddressInterface
     */
    public function __invoke(array $address_data = array()) : AddressInterface
    {
        $address = new $this->php_address_class;
        return $this->apply($address, $address_data);
    }


    /**
     * @param  AddressProviderInterface $address_provider
     * @param  array|null               $address_data
     * @return AddressProviderInterface
     */
    public function apply(AddressProviderInterface $address_provider, array $address_data = null): AddressProviderInterface
    {
        $address = $address_provider->getAddress();

        if (!$address):
            $address = new $this->php_address_class;
            if ($address_provider instanceOf AddressAwareInterface):
                $address_provider->setAddress($address);
            else:
                $address_provider->address = $address;

Accessing address on the interface Germania\Addresses\AddressProviderInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            endif;
        endif;

        $raw = array_merge($this->default_data, $address_data ?: array());

        $address->setStreet1(  $raw['street1'])
                ->setStreet2(  $raw['street2'])
                ->setZip(      $raw['zip'])
                ->setLocation( $raw['location'])
                ->setCountry(  $raw['country'])
                ->setType(     $raw['type']);

        foreach($address_data as $field => $value)                     

The expression $address_data of type null|array is not guaranteed to be traversable. How about adding an additional type check?

            $address->{$field} = $value;

        return $address_provider;
    }
}