ObjectCommand::execute() - Code Metrics - Inspection of "Added checks fro Scrutinizer" - Georgo/wsdl-creator - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fa9233...7f89d9 )

by Tomas

created 2016-03-14 15:44 UTC

ObjectCommand::execute() A

↳ Parent: ObjectCommand

Complexity

Conditions	1
Paths	1

Size

Total Lines	52
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	52
rs	9.4929
cc	1
eloc	38
nc	1
nop	2

How to fix Long Method

<?php
namespace Clients\DocumentLiteralWrapped;

use Clients\InitCommand;
use SoapClient;
use stdClass;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ObjectCommand extends InitCommand
{
    protected function configure()
    {
        $this->setName('document_literal:object');
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->output = $output;

        $this->soapClient = new SoapClient('http://localhost/wsdl-creator/examples/document_literal_wrapped/ObjectExampleSoapServer.php?wsdl', array(
            'uri' => "http://foo.bar/", 'location' => 'http://localhost/wsdl-creator/examples/document_literal_wrapped/ObjectExampleSoapServer.php',
            'trace' => true, 'cache_wsdl' => WSDL_CACHE_NONE
        ));

        $this->serviceInfo('Client Object - document/literal wrapped');

        $this->renderMethodsTable();

        $user = new stdClass();
        $user->name = 'john';
        $user->age = 32;
        $response = $this->soapClient->userInfo(array('info' => $user));
        $this->method('userInfo', array(array('info' => $user)), $response);

        $params = new stdClass();
        $params->name = 'peter';
        $params->number = 999444;
        $response = $this->soapClient->getAgentWithId($params);
        $this->method('getAgentWithId', array($params), $response);

        $namesInfo = new stdClass();
        $namesInfo->names = array('billy', 'clark');
        $namesInfo->id = 333;
        $response = $this->soapClient->namesForId(array('namesInfo' => $namesInfo));
        $this->method('namesForId', array(array('namesInfo' => $namesInfo)), $response);

        $response = $this->soapClient->getCompanies();
        $this->method('getCompanies', array(), $response);

        $response = $this->soapClient->getListOfAgentsWithId();
        $this->method('getListOfAgentsWithId', array(), $response);

        $payments[0] = new stdClass();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        $payments[0]->payment = array(1.21, 3.21, 100.60);
        $payments[0]->user = 'john';
        $payments[1] = new stdClass();
        $payments[1]->payment = array(120.60);
        $payments[1]->user = 'peter';
        $response = $this->soapClient->setPayment(array('payments' => $payments));
        $this->method('setPayment', array(array('payments' => $payments)), $response);

        $response = $this->soapClient->getAgentsWithPayment();
        $this->method('getAgentsWithPayment', array(), $response);

        $response = $this->soapClient->getEmployeesWithAgents();
        $this->method('getEmployeesWithAgents', array(), $response);
    }
}

1			<?php
2			namespace Clients\DocumentLiteralWrapped;
3
4			use Clients\InitCommand;
5			use SoapClient;
6			use stdClass;
7			use Symfony\Component\Console\Input\InputInterface;
8			use Symfony\Component\Console\Output\OutputInterface;
9
10			class ObjectCommand extends InitCommand
11			{
12			protected function configure()
13			{
14			$this->setName('document_literal:object');
15			}
16
17			protected function execute(InputInterface $input, OutputInterface $output)
18			{
19			$this->output = $output;
20
21			$this->soapClient = new SoapClient('http://localhost/wsdl-creator/examples/document_literal_wrapped/ObjectExampleSoapServer.php?wsdl', array(
22			'uri' => "http://foo.bar/", 'location' => 'http://localhost/wsdl-creator/examples/document_literal_wrapped/ObjectExampleSoapServer.php',
23			'trace' => true, 'cache_wsdl' => WSDL_CACHE_NONE
24			));
25
26			$this->serviceInfo('Client Object - document/literal wrapped');
27
28			$this->renderMethodsTable();
29
30			$user = new stdClass();
31			$user->name = 'john';
32			$user->age = 32;
33			$response = $this->soapClient->userInfo(array('info' => $user));
34			$this->method('userInfo', array(array('info' => $user)), $response);
35
36			$params = new stdClass();
37			$params->name = 'peter';
38			$params->number = 999444;
39			$response = $this->soapClient->getAgentWithId($params);
40			$this->method('getAgentWithId', array($params), $response);
41
42			$namesInfo = new stdClass();
43			$namesInfo->names = array('billy', 'clark');
44			$namesInfo->id = 333;
45			$response = $this->soapClient->namesForId(array('namesInfo' => $namesInfo));
46			$this->method('namesForId', array(array('namesInfo' => $namesInfo)), $response);
47
48			$response = $this->soapClient->getCompanies();
49			$this->method('getCompanies', array(), $response);
50
51			$response = $this->soapClient->getListOfAgentsWithId();
52			$this->method('getListOfAgentsWithId', array(), $response);
53
54			$payments[0] = new stdClass();
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-03-14 15:51 UTC by Report Bug Copy Issue Report `$payments` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$payments = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
55			$payments[0]->payment = array(1.21, 3.21, 100.60);
56			$payments[0]->user = 'john';
57			$payments[1] = new stdClass();
58			$payments[1]->payment = array(120.60);
59			$payments[1]->user = 'peter';
60			$response = $this->soapClient->setPayment(array('payments' => $payments));
61			$this->method('setPayment', array(array('payments' => $payments)), $response);
62
63			$response = $this->soapClient->getAgentsWithPayment();
64			$this->method('getAgentsWithPayment', array(), $response);
65
66			$response = $this->soapClient->getEmployeesWithAgents();
67			$this->method('getEmployeesWithAgents', array(), $response);
68			}
69			}

Georgo / wsdl-creator

GitHub Access Token became invalid

Push — master ( fa9233...7f89d9 )

ObjectCommand::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like