WSDL\XML\Styles\RpcEncoded

Complexity

Total Complexity

8

Size/Duplication

Total Lines	41
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

47.62%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	bindingStyle()	4	4	1
A	bindingUse()	4	4	1
A	methodInput()	8	8	2
A	methodOutput()	5	5	1
A	typeParameters()	8	8	2
A	typeReturning()	4	4	1

<?php
/**
 * Copyright (C) 2013-2015
 * Piotr Olaszewski <piotroo89@gmail.com>
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 * of this software and associated documentation files (the "Software"), to deal
 * in the Software without restriction, including without limitation the rights
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 * copies of the Software, and to permit persons to whom the Software is
 * furnished to do so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in
 * all copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */
namespace WSDL\XML\Styles;

use WSDL\Parser\MethodParser;

/**
 * RpcEncoded
 *
 * @author Piotr Olaszewski <piotroo89@gmail.com>
 */
class RpcEncoded extends Style

This class seems to be duplicated in your project.

{
    public function bindingStyle()
    {
        return 'rpc';
    }

    public function bindingUse()
    {
        return 'encoded';
    }

    public function methodInput(MethodParser $method)
    {
        $partElements = array();
        foreach ($method->parameters() as $parameter) {
            $partElements[] = $this->_createElement($parameter);

$parameter is of type object<WSDL\Parser\ParameterParser>, but the function expects a object<WSDL\Types\Type>.

        }
        return $partElements;
    }

    public function methodOutput(MethodParser $method)
    {
        $returnElement = $this->_createElement($method->returning());

It seems like $method->returning() targeting WSDL\Parser\MethodParser::returning() can also be of type array<integer,object<WSDL\Parser\ParameterParser>>; however, WSDL\XML\Styles\Style::_createElement() does only seem to accept object<WSDL\Types\Type>, maybe add an additional type check?

        return $returnElement;
    }

    public function typeParameters(MethodParser $method)
    {
        $elements = array();
        foreach ($method->parameters() as $parameter) {
            $elements[] = $this->_generateType($parameter);
        }
        return $elements;
    }

    public function typeReturning(MethodParser $method)
    {
        return $this->_generateType($method->returning());
    }
}