| Total Complexity | 14 |
| Total Lines | 137 |
| Duplicated Lines | 20.44 % |
| Changes | 0 | ||
Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php namespace GeneaLabs\LaravelModelCaching; |
||
| 10 | class Builder extends EloquentBuilder |
||
| 11 | { |
||
| 12 | protected function cache(array $tags = []) |
||
| 21 | } |
||
| 22 | |||
| 23 | // protected function cacheResults(Relation $relation, array $models, string $name) : array |
||
| 24 | // { |
||
| 25 | // $parentIds = implode('_', collect($models)->pluck('id')->toArray()); |
||
| 26 | // $parentName = str_slug(get_class($relation->getParent())); |
||
| 27 | // $childName = str_slug(get_class($relation->getRelated())); |
||
| 28 | // |
||
| 29 | // $cachedResults = $this->cache([$parentName, $childName])->rememberForever( |
||
| 30 | // "{$parentName}_{$parentIds}-{$childName}s", |
||
| 31 | // function () use ($relation, $models, $name) { |
||
| 32 | // return $relation->match( |
||
| 33 | // $relation->initRelation($models, $name), |
||
| 34 | // $relation->getEager(), |
||
| 35 | // $name |
||
| 36 | // ); |
||
| 37 | // } |
||
| 38 | // ); |
||
| 39 | // |
||
| 40 | // return $cachedResults; |
||
| 41 | // } |
||
| 42 | // |
||
| 43 | // protected function eagerLoadRelation(array $models, $name, Closure $constraints) |
||
| 44 | // { |
||
| 45 | // $relation = $this->getRelation($name); |
||
| 46 | // $relation->addEagerConstraints($models); |
||
| 47 | // $constraints($relation); |
||
| 48 | // |
||
| 49 | // return $this->cacheResults($relation, $models, $name); |
||
| 50 | // } |
||
| 51 | |||
| 52 | protected function getCacheKey(array $columns = ['*'], $ids = null) : string |
||
| 53 | { |
||
| 54 | $key = str_slug(get_class($this->model)); |
||
| 55 | |||
| 56 | if ($ids) { |
||
| 57 | $key .= '_' . (is_array($ids) |
||
| 58 | ? implode('_', $ids) |
||
| 59 | : $ids); |
||
| 60 | } |
||
| 61 | |||
| 62 | if ($columns !== ['*']) { |
||
| 63 | $key .= '_' . implode('_', $columns); |
||
| 64 | } |
||
| 65 | |||
| 66 | $key .= collect($this->query->wheres)->reduce(function ($carry, $where) { |
||
| 67 | $value = $where['value'] ?? implode('_', $where['values']) ?? ''; |
||
| 68 | |||
| 69 | return "{$carry}-{$where['column']}_{$value}"; |
||
| 70 | }); |
||
| 71 | |||
| 72 | if (collect($this->eagerLoad)->isNotEmpty()) { |
||
| 73 | $key .= '-' . implode('-', collect($this->eagerLoad)->keys()->toArray()); |
||
| 74 | } |
||
| 75 | |||
| 76 | if ($this->query->offset) { |
||
| 77 | $key .= "-offset_{$this->query->offset}"; |
||
| 78 | } |
||
| 79 | |||
| 80 | if ($this->query->limit) { |
||
| 81 | $key .= "-limit_{$this->query->limit}"; |
||
| 82 | } |
||
| 83 | |||
| 84 | return $key; |
||
| 85 | } |
||
| 86 | |||
| 87 | protected function getCacheTags() : array |
||
| 88 | { |
||
| 89 | return collect($this->eagerLoad)->keys() |
||
| 90 | ->map(function ($name) { |
||
| 91 | return str_slug(get_class( |
||
| 92 | $this->model |
||
| 93 | ->{$name}() |
||
| 94 | ->getQuery() |
||
| 95 | ->model |
||
| 96 | )); |
||
| 97 | }) |
||
| 98 | ->prepend(str_slug(get_class($this->model))) |
||
| 99 | ->values() |
||
| 100 | ->toArray(); |
||
| 101 | } |
||
| 102 | |||
| 103 | public function count($columns = ['*']) |
||
| 104 | { |
||
| 105 | $tags = [str_slug(get_class($this->model))]; |
||
| 106 | $key = str_slug(get_class($this->model)) ."-count"; |
||
| 107 | |||
| 108 | return $this->cache($tags) |
||
| 109 | ->rememberForever($key, function () use ($columns) { |
||
| 110 | return parent::count($columns); |
||
|
1 ignored issue
–
show
|
|||
| 111 | }); |
||
| 112 | } |
||
| 113 | |||
| 114 | /** |
||
| 115 | * @SuppressWarnings(PHPMD.ShortVariable) |
||
| 116 | */ |
||
| 117 | View Code Duplication | public function find($id, $columns = ['*']) |
|
| 125 | }); |
||
| 126 | } |
||
| 127 | |||
| 128 | View Code Duplication | public function first($columns = ['*']) |
|
| 136 | }); |
||
| 137 | } |
||
| 138 | |||
| 139 | View Code Duplication | public function get($columns = ['*']) |
|
| 147 | }); |
||
| 148 | } |
||
| 150 |