View GitHub Repository laravel-model-caching

Schedule Inspection
Subscribe
Completed
Pull Request — master (#372)
by Mike
31:01 queued 16:07
created

testInRandomOrderCachesResults()   A

↳ Parent: UpdateRelationTest

Complexity

Conditions 1
Paths 1

Size

Total Lines 18

Duplication

Lines 18
Ratio 100 %

Importance

Changes 0
Metric Value
dl 18
loc 18
rs 9.6666
c 0
b 0
f 0
cc 1
nc 1
nop 0
1 
<?php namespace GeneaLabs\LaravelModelCaching\Tests\Integration\CachedBuilder;
2 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    3
                

                                    
                                                    
                
                
                
use GeneaLabs\LaravelModelCaching\Tests\Fixtures\Book;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
use GeneaLabs\LaravelModelCaching\Tests\IntegrationTestCase;

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                

            


            
                                                                                                            
                            
            
                                                                    
                                                                                                        
            
            

                
                    6
                

                                    
                                                    
                
                View Code Duplication
                
class UpdateRelationTest extends IntegrationTestCase

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                        

                                        
There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: artisan, be, call, seed
                                                                                                

                    
                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Duplication
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
This class seems to be duplicated in your project.
                                            

                                            
                    
                                            

                            

                            

                                
                                    
                                
                            


                            
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.


You can also find more detailed suggestions in the “Code” section of your repository.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                                                                            
                                                                
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
{

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
    public function testInRandomOrderCachesResults()

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
    {

            


            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
        $book = (new Book)

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                    
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Bug
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The method first does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloq...ns\QueriesRelationships.
                                                                                                                                                                                                        

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
It seems like the method you are trying to call exists only in some of the
possible types.


Let’s take a look at an example:


class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}







Available Fixes


  1. Add an additional type-check:
    

    /**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo();

    if ($x instanceof B) {
        $x->bar();
    }
}

    

    

    2. 

  2. Only allow a single type to be passed if the variable comes from a parameter:
    

    function someFunction(B $x) { /** ... */ }

    

    

    3. 



                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
            ->with("stores")

            


            
                                                        
            
                                    
            
            

                
                    12
                

                                    
                                                    
                
                
                
            ->whereHas("stores")

            


            
                                                        
            
                                    
            
            

                
                    13
                

                                    
                                                    
                
                
                
            ->first();

            


            
                                                        
            
                                    
            
            

                
                    14
                

                                    
                                                    
                
                
                
        $book->stores()

            


            
                                                        
            
                                    
            
            

                
                    15
                

                                    
                                                    
                
                
                
            ->update(["name" => "test store name change"]);

            


            
                                                        
            
                                    
            
            

                
                    16
                

                                    
                                                    
                
                
                
        $updatedCount = (new Book)

            


            
                                                        
            
                                    
            
            

                
                    17
                

                                    
                                                    
                
                
                
            ->with("stores")

            


            
                                                        
            
                                    
            
            

                
                    18
                

                                    
                                                    
                
                
                
            ->whereHas("stores")

            


            
                                                        
            
                                    
            
            

                
                    19
                

                                    
                                                    
                
                
                
            ->first()

            


            
                                                        
            
                                    
            
            

                
                    20
                

                                    
                                                    
                
                
                
            ->stores()

            


            
                                                        
            
                                    
            
            

                
                    21
                

                                    
                                                    
                
                
                
            ->where("name", "test store name change")

            


            
                                                        
            
                                    
            
            

                
                    22
                

                                    
                                                    
                
                
                
            ->count();

            


            
                                                        
            
                                    
            
            

                
                    23
                

                                    
                                                    
                
                
                

            


            
                                                        
            
                                    
            
            

                
                    24
                

                                    
                                                    
                
                
                
        $this->assertEquals(1, $updatedCount);

            


            
                                                        
            
                                    
            
            

                
                    25
                

                                    
                                                    
                
                
                
    }

            


            
                                                        
            
                                    
            
            

                
                    26
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    27