GeneaLabs / laravel-imagery

src/Console/Commands/Publish.php

<?php namespace GeneaLabs\LaravelImagery\Console\Commands;

use File;
use GeneaLabs\LaravelImagery\Providers\LaravelImageryService;
use Illuminate\Console\Command;
use Illuminate\Contracts\Console\Kernel;

class Publish extends Command
{
    protected $signature = 'imagery:publish {--assets} {--config}';
    protected $description = 'Publish various assets of the Laravel Imagery package.';

    public function handle()
    {
        if ($this->option('assets')) {
            $this->delTree(public_path('genealabs-laravel-imagery'));
            $this->call('vendor:publish', [
                '--provider' => LaravelImageryService::class,
                '--tag' => ['assets'],
                '--force' => true,
            ]);
        }

        if ($this->option('config')) {
            $this->call('vendor:publish', [
                '--provider' => LaravelImageryService::class,
                '--tag' => ['config'],
                '--force' => true,
            ]);
        }
    }

    private function delTree($folder)
    {
        if (! is_dir($folder)) {
            return false;
        }

        $files = array_diff(scandir($folder), ['.','..']);

It seems like scandir($folder) can also be of type false; however, parameter $array1 of array_diff() does only seem to accept array, maybe add an additional type check?

        foreach ($files as $file) {
            is_dir("$folder/$file") ? $this->delTree("$folder/$file") : unlink("$folder/$file");
        }

        return rmdir($folder);
    }
}