GeneaLabs / laravel-caffeine

tests/CreatesApplication.php

<?php namespace GeneaLabs\LaravelCaffeine\Tests;

use GeneaLabs\LaravelCaffeine\Providers\Service as LaravelCaffeineService;

trait CreatesApplication
{
    protected function refreshApplication()
    {
        putenv('APP_ENV=internaltesting');

        $this->app = $this->createApplication();

The property app does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

It seems like createApplication() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
    
    /**
     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
     */
    protected function getPackageProviders($app)

The parameter $app is not used and could be removed.

    {
        return [LaravelCaffeineService::class];
    }
}