Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | class DBBackupFile implements BackupFile |
||
16 | { |
||
17 | private $path; |
||
18 | |||
19 | public function __construct(string $path) |
||
26 | |||
27 | public function exists() : bool |
||
31 | |||
32 | public function name() : string |
||
36 | |||
37 | public function basename() : string |
||
41 | |||
42 | public function dirname() : string |
||
46 | |||
47 | public function extension() : string |
||
51 | |||
52 | public function path() : string |
||
56 | |||
57 | View Code Duplication | public function move(string $destination) : BackupFile |
|
66 | |||
67 | View Code Duplication | public function copy(string $destination) : BackupFile |
|
76 | } // END class BasicBackupFileNameGenerator |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.