Completed
Pull Request — master (#1)
by Albin
01:57
created

AwsS3PublicUrlResolverTest   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 12
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 6

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 1
lcom 1
cbo 6
dl 12
loc 12
rs 10
c 1
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A getFilesystem() 7 7 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Gaufrette\Extras\Tests\Resolvable\Resolver;
4
5
use Gaufrette\Adapter\AwsS3;
6
use Gaufrette\Extras\Resolvable\ResolvableFilesystem;
7
use Gaufrette\Extras\Resolvable\Resolver\AwsS3PublicUrlResolver;
8
use Gaufrette\Filesystem;
9
10 View Code Duplication
class AwsS3PublicUrlResolverTest extends TestCase
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
11
{
12
    use AwsS3SetUpTearDownTrait;
13
14
    protected function getFilesystem()
15
    {
16
        return new ResolvableFilesystem(
17
            new Filesystem(new AwsS3($this->client, $this->bucket, ['create' => true])),
18
            new AwsS3PublicUrlResolver($this->client, $this->bucket, '', new \DateTime('+1 minute'))
0 ignored issues
show
Unused Code introduced by
The call to AwsS3PublicUrlResolver::__construct() has too many arguments starting with new \DateTime('+1 minute').

This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.

If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.

In this case you can add the @ignore PhpDoc annotation to the duplicate definition and it will be ignored.

Loading history...
19
        );
20
    }
21
}
22