garethp\ews\ContactsAPI

Complexity

Total Complexity

14

Size/Duplication

Total Lines	129
Duplicated Lines	56.59 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

83.02%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	pickContact()	13	13	4
A	getFolderId()	0	8	2
A	setFolderId()	0	4	1
A	getContacts()	22	22	2
A	getContact()	0	4	1
A	createContacts()	18	18	2
A	updateContactItem()	20	20	2

<?php

namespace garethp\ews;

use garethp\ews\API\Type;

class ContactsAPI extends API
{
    /**
     * @var Type\FolderIdType
     */
    protected $folderId;

    /**
     * Pick a Contacts based on it's folder name
     *
     * @param string|null $displayName
     * @return $this
     */
    public function pickContact($displayName = null)

This method seems to be duplicated in your project.

    {
        if ($displayName == 'default.contacts' || $displayName == null) {

It seems like you are loosely comparing $displayName of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

            $folder = $this->getFolderByDistinguishedId('contacts');
        } else {
            $folder = $this->getFolderByDisplayName($displayName, 'contacts');
        }
        if (!$folder) {
            return false;   

The return type of return false; (false) is incompatible with the return type documented by garethp\ews\ContactsAPI::pickContact of type garethp\ews\ContactsAPI.

        }
        $this->folderId = $folder->getFolderId();

The method getFolderId does not exist on object<garethp\ews\API\Type>? Since you implemented __call, maybe consider adding a @method annotation.

        return $this;
    }
    
    /**
     * @return Type\FolderIdType
     */
    public function getFolderId()
    {
        if (!$this->folderId) {
            $this->folderId = $this->getFolderByDistinguishedId('contacts')->getFolderId();

The method getFolderId does not exist on object<garethp\ews\API\Type>? Since you implemented __call, maybe consider adding a @method annotation.

        }

        return $this->folderId;
    }

    /**
     * @param Type\FolderIdType $folderId
     */
    public function setFolderId($folderId)
    {
        $this->folderId = $folderId;
    }

    /**
     * @param Type\FolderIdType $folderId
     * @param array $options
     * @return Type\ContactItemType[]
     */
    public function getContacts($folderId = null, $options = array())

This method seems to be duplicated in your project.

    {
        if (!$folderId) {
            $folderId = $this->getFolderId();
        }

        $request = array(
            'Traversal' => 'Shallow',
            'ItemShape' => array(
                'BaseShape' => 'AllProperties'
            ),
            'ParentFolderIds' => array(
                'FolderId' => $folderId->toXmlObject()
            )
        );

        $request = array_replace_recursive($request, $options);

        $request = Type::buildFromArray($request);

        return $this->getClient()->FindItem($request);
    }

    /**
     * @param Type\ItemIdType $itemId
     * @return Type\ContactItemType
     */
    public function getContact($itemId)
    {
        return $this->getItem($itemId);
    }

    /**
     * @param $contacts
     * @param array $options
     * @return Type\ItemIdType[]
     */
    public function createContacts($contacts, $options = array())

This method seems to be duplicated in your project.

    {
        $request = array('Contact' => $contacts);

        $defaultOptions = array(
            'MessageDisposition' => 'SaveOnly',
            'SavedItemFolderId' => array('FolderId' => $this->getFolderId()->toArray())
        );
        $options = array_replace_recursive($defaultOptions, $options);

        $result = $this->createItems($request, $options);

        if (!is_array($result)) {
            $result = array($result);
        }

        return $result;
    }

    public function updateContactItem(Type\ItemIdType $itemId, $changes)

This method seems to be duplicated in your project.

    {
        //Create the request
        $request = array(
            'ItemChange' => array(
                'ItemId' => $itemId->toArray(),
                'Updates' => API\ItemUpdateBuilder::buildUpdateItemChanges('Contact', 'contacts', $changes)
            )
        );

        $options = array();

        $items = $this->updateItems($request, $options);

        if (!is_array($items)) {
            $items = array($items);
        }

        return $items;
    }
}